You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the PR. Could I ask you make a small change. The various INIReader.read() methods should probably now throw INIParseException instead of ParseException, and Javadocs updated accordingly. This may break backwards compatibility for some users using INIReader directly, so I'll hold off merging this until 0.6.0-SNAPSHOT . I 'll merge your other PR and another minor typo into 0.5.6-SNAPSHOT before this though.
The convenience from*() methods in INI should now catch INIParseException and rethrow IllegalStateException instead.
I will note that this PR is fully compatible with existing code. INIParseException extends ParseException, meaning that old catch blocks will still work. Narrowing the type of a thrown exception, from a method inside a final class, is never a contractually incompatible change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The line number starts from 0 reflecting how it is used in the parser