Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: skip send to partial channel on diff #5880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2025
Merged

fix: skip send to partial channel on diff #5880

merged 1 commit into from
Aug 3, 2025

Conversation

@jamesgibbons92
Copy link
Contributor

Resolves #5856

partial channel was filling up during sst diff but this channel is not consumed in this mode due to this go routine:

	go func() {
		if input.Command == "diff" {
			return
		}
		for {
			select {
			case <-partialContext.Done():
				partialDone <- nil
				return
			case <-partial:
				workdir.PushPartial(update.ID)
			case <-time.After(time.Second * 5):
				workdir.PushPartial(update.ID)
				continue
			}
		}
	}()

so once the buffer hit 1000 it started blocking and causes the command to hang indefinitely.

@jamesgibbons92 jamesgibbons92 mentioned this pull request Jun 10, 2025
Closed
@jamesgibbons92 jamesgibbons92 changed the title skip send to partial channel on diff fix: skip send to partial channel on diff Jun 10, 2025
@jayair jayair requested a review from thdxr June 13, 2025 22:59
@lkhari
Copy link

lkhari commented Jul 21, 2025

Any update on getting this merged @thdxr ? I have a few large projects that strugles with diff now.

@thdxr thdxr merged commit 50f2705 into sst:dev Aug 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thdxr thdxr Awaiting requested review from thdxr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sst diff hanging

3 participants

@jamesgibbons92 @lkhari @thdxr