Update setuptools #162
Merged
Update setuptools #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
sanmai
approved these changes
Jan 17, 2023
pyproject.toml
Outdated
| [project.urls] | ||
| "Homepage" = "https://github.com/tumblr/pytumblr" | ||
| "Bug Tracker" = "https://github.com/tumblr/pytumblr/issues" | ||
| "Download" = "https://github.com/tumblr/pytumblr/archive/0.1.1.tar.gz" |
There was a problem hiding this comment.
Suggested change
| "Download" = "https://github.com/tumblr/pytumblr/archive/0.1.1.tar.gz" |
If we don't include this line we won't have to update it every time. What do you think?
There was a problem hiding this comment.
Nice catch. I changed it to link to the Releases page.
sanmai
reviewed
Jan 17, 2023
| $ git clone https://github.com/tumblr/pytumblr.git | ||
| $ cd pytumblr | ||
| $ python setup.py install | ||
| $ python -m build |
There was a problem hiding this comment.
Do we need to update .github/workflows/ci.yaml as well?
There was a problem hiding this comment.
The PR build wasn't working for you because the testing steps didn't include installing build. I updated the instructions and ci.yaml to include installing and using build.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #157
What
This PR
setuptoolsbuild command instead of the deprecatedsetup.pyscriptTesting
distandbuildfolders if they exist in the root of the repositorypython -m pip install --upgrade pip wheel buildpython -m buildpython interactive_console.pyclientmethods from the README