Add params-in-body support to DELETE #138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge upstream
Tumblr has a few API routes that use DELETE but require the params be placed in the request body, not on the URL
sndsgd
reviewed
Oct 29, 2019
| return self.send_api_request("post", url, params, valid_options) | ||
|
|
||
| def send_api_request(self, method, url, params={}, valid_parameters=[], needs_api_key=False): | ||
| def send_api_request(self, method, url, params={}, valid_parameters=[], needs_api_key=False, use_body=False): |
There was a problem hiding this comment.
while i'm not exactly sure what to do here, this feels a bit weird for a few reasons:
- this is a parameter that is only really available when
method == "delete" - this means that we cannot use both query parameters and body parameters
i think the ideal here would be to have two separate arguments, query_params and body_params so we have the ability to send both. its not following any best practices to go that route, but it does cover all the bases so we can handle oddities that exist in various legacy api routes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tumblr has a few API routes that use DELETE but require the params be placed in the request body, not on the URL