Resolve #153. Possibilita o usuário editar seus dados #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turicas
requested changes
Feb 7, 2019
Owner
turicas
left a comment
There was a problem hiding this comment.
Obrigado pelas contribuições, Ítalo! Adicionei alguns comentários sobre mudanças.
brasilio_auth/urls.py
Outdated
| path('troca-senha/atualizada/', views_config['password_reset_complete'], name='password_reset_complete'), | ||
| path('logout/', views_config['logout'], name='logout'), | ||
| path('entrar/', CreateUserView.as_view(), name='sign_up'), | ||
| path('editar-perfil/<int:user_id>', ProfileUpdate.as_view(), name='profile_update_form') |
Owner
There was a problem hiding this comment.
Como o usuário estará logado, não necessitamos passar seu id pela URL pois podemos pegá-lo diretamente por request.user.id (exemplo, para atualizar seu perfil no GitHub, a URL é a mesma para todos usuários: https://github.com/settings/profile).
| return redirect(url) | ||
|
|
||
|
|
||
| class ProfileUpdate(UpdateView): |
Owner
There was a problem hiding this comment.
Como para acessar essa página o usuário precisa estar logado, precisamos adicionar aqui o decorator login_required - veja exemplo na documentação do Django.
Author
|
Removi a pk da url, adicionei o login_required pra editar o perfil do usuário e resolvi o conflito com a branch develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.