Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix RTRIM ignoring trailing tabs #3891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix RTRIM ignoring trailing tabs #3891

wants to merge 2 commits into from

Conversation

@krishvishal
Copy link
Contributor

@krishvishal krishvishal commented Nov 1, 2025 •
edited
Loading

str::trim_end() removes trailing tabs too. Replaced it with trim_end_matches(' '). Rust str::trim functions seem problematic because they remove non-ascii whitespace and others.

Behavior now:

turso> select 'x' || char(9) = 'x' collate rtrim;
┌─────────────────────────────────────┐
│ 'x' || char (9) = 'x' COLLATE rtrim │
├─────────────────────────────────────┤
│                                   0 │
└─────────────────────────────────────┘

Closes: #3480

@nyrkio
Copy link

nyrkio bot commented Nov 1, 2025 •
edited
Loading

Nyrkiö Report for Commit: f12f982

No performance changes detected.
Remember that Nyrkiö results become more precise when more commits are merged.
So please check again in a few days.

Nyrkiö 0 changes / 51 tests & 51 metrics.

@krishvishal
Copy link
Contributor Author

krishvishal commented Nov 1, 2025

Not sure why the benchmark action failed. Seems unrelated to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jussisaurio jussisaurio Awaiting requested review from jussisaurio jussisaurio is a code owner

@penberg penberg Awaiting requested review from penberg penberg is a code owner

Assignees

No one assigned

Labels

core translation/planning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RTRIM should not ignore trailing tabs

1 participant

@krishvishal