-
Notifications
You must be signed in to change notification settings - Fork 1
Search Screen and other improvements. #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All green theme was looking a bit odd so green-blue-yellow combo is used. App dependencies in libs.versions.toml are updated to the newest one's. Removed material-icons extended.
All the dependencies and Kotlin version updated.
BluetoothScoUseCase replaced onEach with collect. In PhoneStateObserverUseCase only start the observer settings is activated. Corrected through flow operators. Simplified RecordingsBinViewmodel and RecordingsViewmodel, fixed the category loading logic. in RecordingsFromCategoriesUseCase no need to check for null type for recordingCategories models. In UIEventHandler.kt remembering the flow then collecting it, The other handlers associated with recordings are also updated.
The screen binds the service only if the permission is provided and the content is only the body of the scaffold the top bar will persist in the binding state of the microphone. RecorderContent is the content from the service values that was directly representing the route. BooksMarks read is also deferred in graph.
For shared element transition we need two scopes they are provided via CompositionLocals.kt again the wrapper around the modifiers are also added in sharedElementWrapper. sharedElement keys are added in SharedElementTransitionKeys. All the routes are wrapped by CompositionLocalsProvider with the animated visibility scope. Basic shared bounds (container transform ) is added for audioPlayerRoute. In player route the app bar is made persistent. Corrected the logic for api call in renameRecordingDialog for renaming recording file.
ManageCategoriesScreen is simplified , cards now have edit and delete options rather than selecting the elements. CreateOrEditCategoryScreen is associated with a container transform. Added labels to the type selector for categories. SelectCategoryScreen and ManageCategoriesScreen are kind of same just one allows selecting the category and the other allows config to the category. In Bin screen and recordings screen remove the icon and use text button which smoothly translate in shared transition. SortOptionsSheetContent radio buttons are moved to the right. Other changes are simplification of the composable.
Updated compose-bom dependency and added material icon extended. Search Filter options categorical search and time filters. Only the screen is prepared actual functionality is not yet made. Search bar can't be used in the recording screen thus a different route.
Added some documentations for providers in recordings providers. Corrected some logic in providers impl. The logic is just changed implementation kept the same.
Bluetooth,PhoneStateObserver and ShareRecordingsUtil are bare interactions along with the app. CombineRecordingSources combines the 2 recording models one from content-resolver and other from room databases.
Rather than using a search bar in expanded form a scaffold is used with list and a text field filters are selected from the modal bottom sheet.
An intent will fire and the results are capture based on the results query is made. Added tooltip box to the icons.
…ections. SettingsScreen list-tile container color is set transparent and other Ui changes. RecorderTopBar action list to recordings screen shared bounds transition. Corrected the strings.xml resources .
Search and categories screen screenshots attached. Bumped version code to 7 and version name to 1.2.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes and New Features
And some other Ui and code fixes