Made some fixes and some error correction #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly navigation icon in all the routes are wrapped with if previous back-stack entry exists otherwise it's useless. In AudioPlayerViewModel shortcuts are added only if the AudioFileModel is loaded successfully, otherwise it's not . Added the animation spec for the bookmarks and list animated content. A bit of refactoring for the RecordingCard, rows-> column and vise versa. Fixed the StorageStatistics card. Primarily the data was wrong and the graph was not showing it properly , fixed that.
Player screen was not able to load the recordings due to RecordingSecondaryDataProviderImpl.getRecordingFromIdAsFlow returning an empty flow, but it should emit at-least a null for PlayerFileProviderFromIdUseCase to work. Fixed the issue. Not adding any scope to callback flow as I can launch a coroutine via `launch` inside the producer scope. As per the problem of reading external recording not a lot of it is fixed but still working on it. For the meantime simplified the logic to hold the recording in other flows.
They were not used anywhere in the codebase so removed them. In VoiceRecordingsProviderImpl.voiceRecordingsOnlyThisApp yes we need to keep the flow alive for new changes in the recordings otherwise changes will be not be viewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ui fixes and correction
Modifier.fillMaxWidth()thus the ratio was incorrect, again float conversion was incorrect, and indicator was showing free space as text and graph was opposite, corrected that to show used space.RecordingsCardfixed the layout , and added an extra supporting text to show if its from other app.RecorderTopBarno animation spec was provided.PlayerScreen.previousBackStackEntry?.destination?.route != nullto ensure not to show the nav-icon if no previous back stack is not present.Data layer correction
RecordingsSecondaryDataProviderwhile querying for secondary data added afilterNotNullbut the flow needs to emit something to runPlayerFileProviderFromIdUseCasedue to which the player screen was stuck inLoadingState.VoiceRecordingProviderongetVoiceRecordingsadded an param which determines whether to query out all recordings or not. This is put in aContentObserverflow withflatMapwith settings.Conclusion
The bugs aren't fixed completely , but momentarily everything seems working and the
VoiceRecordingProviderImplis lot readable now. As this class is responsible for the whole job. If error occurs later it will be fixed then.