Updated width and height attributes #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
reviewed
Dec 1, 2020
Fixes broken rendering of 1x1px when opening current icons in Sketch, Illustrator, etc. Also reprocesses icons to reorder the attributes. Fixes #492
leafac
added a commit
to leafac/icons
that referenced
this pull request
Apr 29, 2021
The documentation still states that the SVGs width and height are `1em`, while that’s no longer the case: twbs#497
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, our icons don't open well in Sketch, Illustrator, etc because the
widthandheightof1emregisters as1pixel. This drops the width and height conversion from our build script and updates thewidthandheightto16. This doesn't mean you cannot use1emas a height or width, in CSS or otherwise, just that by default we'll use pixels to ensure more consistent rendering.Fixes #492.