Sprite SVG #274
Merged
Sprite SVG #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
reviewed
Jun 2, 2020
| "shx": "^0.3.2", | ||
| "stylelint": "^13.5.0", | ||
| "stylelint-config-twbs-bootstrap": "^2.0.2", | ||
| "svg-sprite": "^1.5.0", |
There was a problem hiding this comment.
This is using obsolete dependencies...
|
@mdo Also, SVGO does not seem to run for the sprite image? EDIT: NVM, I see SVGO is the default svg-sprite transform :) Although, not sure what config it's using, but if it works, it works. EDIT2: What I don't like is that we load another huge file on page load... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on and replaces #262 with several changes: