Fix array field migration #12874
Merged
Fix array field migration #12874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
PR Summary
Fixed a regression where array column types weren't properly formatted in SQL migrations. The typeormBuildCreateColumnSql utility now correctly appends [] suffix for array types.
- Modified
packages/twenty-server/src/engine/workspace-manager/workspace-migration-runner/utils/internal/typeorm-build-create-column-sql.util.tsto properly handle array types in SQL column creation - Fixed regression where types like
text[]were incorrectly created as justtext - Added special handling for enum arrays using 'array' keyword instead of
[]suffix
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
Weiko
commented
Jun 25, 2025
...ce-manager/workspace-migration-runner/utils/internal/typeorm-build-create-column-sql.util.ts
Outdated
Show resolved
Hide resolved
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:64377 This environment will automatically shut down when the PR is closed or after 5 hours. |
charlesBochet
approved these changes
Jun 25, 2025
Weiko
added a commit
that referenced
this pull request
Jun 25, 2025
Fixes #12726 ## Context Regression introduced in #12639 We now run raw queries for some migrations (column creations for example) and we created a `typeormBuildCreateColumnSql` util for that. The issue is that previously we were using typeorm methods which was using isArray from the input to create $type[] (text[], number[]) properly which was not done in the new `typeormBuildCreateColumnSql` util (so the type was text, number, etc...) Edit: actually this was correctly implemented for Enum types (multi select fields) but not Array type, I've updated the code accordingly
Weiko
added a commit
that referenced
this pull request
Jun 25, 2025
Fixes #12726 ## Context Regression introduced in #12639 We now run raw queries for some migrations (column creations for example) and we created a `typeormBuildCreateColumnSql` util for that. The issue is that previously we were using typeorm methods which was using isArray from the input to create $type[] (text[], number[]) properly which was not done in the new `typeormBuildCreateColumnSql` util (so the type was text, number, etc...) Edit: actually this was correctly implemented for Enum types (multi select fields) but not Array type, I've updated the code accordingly
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 26, 2025
Fixes twentyhq#12726 ## Context Regression introduced in twentyhq#12639 We now run raw queries for some migrations (column creations for example) and we created a `typeormBuildCreateColumnSql` util for that. The issue is that previously we were using typeorm methods which was using isArray from the input to create $type[] (text[], number[]) properly which was not done in the new `typeormBuildCreateColumnSql` util (so the type was text, number, etc...) Edit: actually this was correctly implemented for Enum types (multi select fields) but not Array type, I've updated the code accordingly
Weiko
added a commit
that referenced
this pull request
Jun 26, 2025
Following this fix #12874 we now need to add a command to retroactively fix existing columns --------- Co-authored-by: Paul Rastoin <[email protected]> Co-authored-by: prastoin <[email protected]>
prastoin
added a commit
that referenced
this pull request
Jun 26, 2025
Following this fix #12874 we now need to add a command to retroactively fix existing columns --------- Co-authored-by: Paul Rastoin <[email protected]> Co-authored-by: prastoin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12726
Context
Regression introduced in #12639
We now run raw queries for some migrations (column creations for example) and we created a
typeormBuildCreateColumnSqlutil for that.The issue is that previously we were using typeorm methods which was using isArray from the input to create $type[] (text[], number[]) properly which was not done in the new
typeormBuildCreateColumnSqlutil (so the type was text, number, etc...)Edit: actually this was correctly implemented for Enum types (multi select fields) but not Array type, I've updated the code accordingly