feat(crawler): fixing crawl functionality #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update gitignore and add timeout to HTTP client. - reverted to simple queue.
- added zerolog logger. - removed OnError Method.
- refactor metrics monitoring and add new metrics
- updated readme. - added .dev extention. - fix mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motive
this MR to fix issue with the crawling functionallity of the bot. the issue was with default fetcher that was using the
http.Clientthat and it will block if the request takes too long to respond. the fix was to usehttp.Clientwith a timeout and a custom transport that will limit the number of concurrent requests.Changes
OnErrorMethod.