Remove a quadradic function in our cascading3 support #1779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! I… clearly get some blame for this in https://github.com/twitter/scalding/blame/cascading3/scalding-core/src/main/scala/com/twitter/scalding/RichPipe.scala#L150 but I don't remember. Trial & error for sure, and most certainly not tried at all with MAPREDUCE (is anyone still using that ? ;) ) |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was appending to a list, which is an O(N) operation in a loop. In the end, we only want a set, so the order does not matter. So, I changed to prepending, which is O(1), and then calling toSet at the end.
@cchepelov I think you wrote some of this stuff originally. I'm trying to understand the rules we need to follow to make sure cascading3 does not throw at plan time.
I'm still seeing some exceptions in our generative testing in some cases. Where did you learn the rules? Trial and error?
cc @cwensel