MergeableMySqlStore and MySqlLongStore #181
Conversation
There was a problem hiding this comment.
Can I challenge you to implement multiMerge? Merge is implemented in terms of that, so you get that for free. Is that too hard?
There was a problem hiding this comment.
It looks like implementing multiMerge will require directly executing INSERT or UPDATE queries, instead of relying on the underlying put (which in-turn executes its own SELECT query per key to decide whether to INSERT or UPDATE).
Definitely doable. (We lose the ability to re-use the type-converted put that ConvertedStore provides us, but we gain more control and avoid redundant SELECT queries being run for merges.)
Will update the pull req with this.
|
Implemented multiMerge. Looks a lot like MySqlStore's multiPut. |
There was a problem hiding this comment.
.map here and not bother with lifting into Future.value.
|
Looking really good. Anxious to see someone use this with summingbird in production and see how well it does. |
|
Yeah, will be interesting to see; quite a different beast than memcache or redis. |
MergeableMySqlStore and MySqlLongStore
|
So good. This might be really useful for Kevin, Alberto and Zichong. |
|
Thanks guys! We're looking forward to using this new version of summingbird when it's available in science. |
Addresses #85
Also added
MySqlLongStoreon the lines ofRedisLongStore.