-
Couldn't load subscription status.
- Fork 266
Yet another cache #470
Yet another cache #470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be a val?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, should really just be undefined for the concrete class to specify it . Going for the notion its a def here, but a val in the concrete class so the clean up will work ok from here.
(If we decide to keep the MultiTriggerCache it can hopefully just use these traits too.)
…ion. Also simplified the yet another cache to have less synchronization concerns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to understand the CacheSize class..
Wouldn't the two calls to cacheSizeOpt.size.get in this class return different values? Is that okay for this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is just badness, i'm not entirely sure why we have the fudge factor on the CacheSize, but this isn't good. Will change it to the one call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, no docs there :) It's because if all the cache sizes are the same, storm will buffer in every bolt for roughly the same period and then EMIT!!! Then the network dies and @singhala commits seppuku.
The fuzz allows buffering, with a good distribution of network activity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh, thanks for the info. I wonder if we need it anymore with the MaxEmitForExecute options, seems it still didn't like cache flushes... locks up all the queue insertion points :) Doesn't do any harm anyway
…herCache Conflicts: project/Build.scala
|
Sorry about the delay in updating, finally got back to this. Merged up to master, comments addressed I think |
|
@johnynek This look ok to merge? |
|
bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: Background
|
Should all be fixed/building now |
|
Thanks for the epic patience. Any other reviews can be in the form of bug fixes ;) |
Faster in microbenchmarks on the cache::