This repository was archived by the owner on Jan 20, 2022. It is now read-only.
add variations on pipeFactory to allow a map function before time extrac... #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asiegel34 This seems like its something you might want too, any feedback on it? |
|
One question would be whether pipeFactoryExact also should have these variants (also if the copying between pipeFactory and pipeFactoryExact could be reduced)? I haven't needed that yet, but I'm also not far enough along in experimenting to understand exactly what it's for. |
|
This code does not even touch storm, so the test failure must be spurious. Going to merge. We can add more later. @kscaldef Thanks! |
johnynek
added a commit
that referenced
this pull request
Mar 19, 2014
add variations on pipeFactory to allow a map function before time extrac...
snoble
pushed a commit
to snoble/summingbird
that referenced
this pull request
Sep 8, 2017
…ionHaveSnapshotSuffix Ioconnell/make develop version have snapshot suffix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...tion