This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Add some option documentation #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The SummerBatchMultiplier is to make smaller chunks of the data sent from the FM to the Summers. More summers would mean more threads, sometimes you need/want there to be more packets and each one that bit smaller, so this has that effect |
|
ping @ianoc |
|
Sorry my bad, merged |
snoble
pushed a commit
to snoble/summingbird
that referenced
this pull request
Sep 8, 2017
Speed up HLL presentation by 100x
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stab at #385, though the wiki should be updated as well.
The only one I didn't really get was SummerBatchMultiplier. I see how it is used, but am not sure why it is necessary (instead of just using SummerParallelism). It seems the two are never used independently of each other.
Feel free to suggest where this can be expanded. Once this is done, we can use the existing documentation etc to update the wiki.