This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Ianoc/optimization changes #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lculations for a type that ends up in a map
…st a Timestamp or BatchID in groupings
There was a problem hiding this comment.
does this need to be a lazy val? Maybe just val and not have the thread sync costs? hashCode of a Long must be really fast.
…tamp classes here we should just proxy them through. Calling hashcode on an Int/Long is extremely cheap (its the identity function). Case class hash codes are different/more expensive using product iterators
There was a problem hiding this comment.
looks like we are always going to hit the hashCode here. Maybe drop lazy and just directly val it?
There was a problem hiding this comment.
Sure yeah makes sense
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few relatively minor changes to improve some SB performance in scalding jobs