This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Fixes a bug in the LTuple2 class. Add a test for it #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Just curious how this holds true given LTuple2 and Tuple2 don't have any type hierarchy between them. This will break if the ScalaRunTime implementation changes in the future?
There was a problem hiding this comment.
Both LTuple2 and Tuple2 are case classes, and both use the case class hash code method. So they should be synchronized across any upgrades. If something happens and that doesn't hold then its probably good we look at this for this test failing
|
LGTM, merge when green |
|
👍 |
ianoc
added a commit
that referenced
this pull request
Nov 13, 2015
Fixes a bug in the LTuple2 class. Add a test for it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.