This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Fix a bug in memory platforms with redundant also #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It also fixes #646 |
There was a problem hiding this comment.
here is the bug that hits ConcurrentMemory.
There was a problem hiding this comment.
The bug here is that the dependantsOf(p) != r in this case?
There was a problem hiding this comment.
yes, I was looking up the graph, then dependantsOf brought me back down, causing an infinite loop. Wrong direction.
|
LGTM, maybe minor comment update if the revision makes sense. |
ianoc
added a commit
that referenced
this pull request
Dec 11, 2015
Fix a bug in memory platforms with redundant also
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the tests in #645, verifies that bug manifests, then I fixed the bug. Seems to fix #631 for real. /cc @pankajroark