Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix token secret cli parsing #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2018
Merged

fix token secret cli parsing #91

merged 1 commit into from
Jul 5, 2018

Conversation

@woparry
Copy link
Contributor

@woparry woparry commented Jun 20, 2018

Problem

twurl crashes with a confusing error like

0.9.3/lib/twurl/oauth_client.rb:138:in `gets': No such file or directory @ token_secret

when you supply the -S parameter to twurl authorize ie.

twurl authorize -c client -s client_secret -a token -S token_secret

because the -S parameter does not take an argument, even though the docs say it should

Solution

make -S take an argument (and test that we can parse the argument)

Result

it doesn't crash

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2018 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

coveralls commented Jun 20, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 88.173% when pulling 5610df3 on woparry:op/fix-token-secret into d561e70 on twitter:master.

@andypiper andypiper self-assigned this Jun 23, 2018
@andypiper
Copy link
Contributor

andypiper commented Jul 3, 2018

Hi @woparry thanks for the PR - license helper is showing the CLA is not signed yet. If you could double-check, I can bring this in later today.

@andypiper andypiper self-requested a review July 3, 2018 09:32
@andypiper andypiper mentioned this pull request Jul 3, 2018
Closed
andypiper
andypiper approved these changes Jul 3, 2018
View reviewed changes
Copy link
Contributor

@andypiper andypiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and LGTM. Thanks. Just waiting on CLA to come out of pending state.

@woparry
Copy link
Contributor Author

woparry commented Jul 3, 2018

Thanks! I clicked on the link and it says "you have signed the CLA for twitter/twurl", but when I click "recheck" on this page nothing happens.

@andypiper
Copy link
Contributor

andypiper commented Jul 5, 2018

OK I'm going to go ahead and merge (but will not immediately make a new release) - need to look into this CLA thing, it might be broken.

@andypiper andypiper merged commit e4686b4 into twitter:master Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andypiper andypiper andypiper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andypiper andypiper

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@woparry @CLAassistant @coveralls @andypiper @paradigmsort