implementation of an auth file, for scala and java. #1
Conversation
There was a problem hiding this comment.
what does the non-greedy .*? do for you here? why does it need a match? Could this be simpler:
"(?:\\s+|#.*\\n)+".r
There was a problem hiding this comment.
i got paranoid when my initial version didn't work. looks like yours works fine too. changed!
|
Generally, LGTM. |
|
pushed tweaks. |
|
I guess we don't believe in java Properties? |
|
We expect ruby servers will be using them too, so we want them to just be On Mon, Apr 4, 2011 at 10:37, fizx <
|
|
Ah, makes sense. What's auth-specific here? Should we call this some variation of config/props/etc files? |
|
In the doc (please help review! Look for an email from Bob with subject On Mon, Apr 4, 2011 at 11:15, fizx <
|
* Create a new EvaluateTaskConfig which gives us a bit more freedom over changign config options to EvaluateTask in the future. * Create adapted from old EvaluateTask to new EvaluateTask * Add hooks into signals class to register/remote a signal listener directly, rather than in an "arm" block. * Create TaskEvaluationCancelHandler to control the strategy of who/whom can cancel (sbt-server vs. sbt-terminal). * Create a null-object for the "can't cancel" scenario so the code path is exactly the same. This commit does not wire settings into the build yet, nor does it fix the config extractio methods.
Setup travis, public tests in utilLogging
Use IO.getModified over importing the method
holla!