-
Notifications
You must be signed in to change notification settings - Fork 57
Split out ember-tsc and Glint 2 extension for hybrid upgrade strategy #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| - [Ember.js Installation](ember/installation.md) | ||
| ```typescript | ||
| import '@glint/ember-tsc/types'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should mention this can also go in TSconfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
docs-v2/getting-started.md
Outdated
|
|
||
| - Install the [VS Code Extension](https://marketplace.visualstudio.com/items?itemName=typed-ember.glint-vscode). | ||
| - Install the [VS Code Extension](https://marketplace.visualstudio.com/items?itemName=typed-ember2.glint-vscode). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the tooling folks to this new org?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, no new org... put the two in the wrong place, should be typed-ember.glint2-vscode, fixing...
|
|
||
| vscode.window | ||
| .showErrorMessage( | ||
| `The Glint V1 extension (typed-ember.glint-vscode) can not be enabled at the same time as the Glint V2 extension. Please disable one (either globally or in your workspace) and reload your workspace.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done
|
The link above "new v2 upgrade instructions" doesn't go to instructions, I think perhaps it should be: https://github.com/typed-ember/glint/blob/main/docs/v2-upgrade.md |
Implement #978
As part of this PR I published Glint 2 on the VSCode marketplace with the orange icon as well as
@glint/ember-tscon NPM.I was able to follow along with the new v2 upgrade instructions; folk are welcome and encourage to try this upgrade themselves!