Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@machty
Copy link
Contributor

@machty machty commented Sep 30, 2025

Implement #978

As part of this PR I published Glint 2 on the VSCode marketplace with the orange icon as well as @glint/ember-tsc on NPM.

I was able to follow along with the new v2 upgrade instructions; folk are welcome and encourage to try this upgrade themselves!

@machty machty changed the title ember-tsc spike Split out ember-tsc and Glint 2 extension for hybrid upgrade strategy Sep 30, 2025
@machty machty marked this pull request as ready for review September 30, 2025 10:45
@machty machty mentioned this pull request Sep 30, 2025

- [Ember.js Installation](ember/installation.md)
```typescript
import '@glint/ember-tsc/types';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mention this can also go in TSconfig

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines 48 to 49

- Install the [VS Code Extension](https://marketplace.visualstudio.com/items?itemName=typed-ember.glint-vscode).
- Install the [VS Code Extension](https://marketplace.visualstudio.com/items?itemName=typed-ember2.glint-vscode).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the tooling folks to this new org?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, no new org... put the two in the wrong place, should be typed-ember.glint2-vscode, fixing...


vscode.window
.showErrorMessage(
`The Glint V1 extension (typed-ember.glint-vscode) can not be enabled at the same time as the Glint V2 extension. Please disable one (either globally or in your workspace) and reload your workspace.`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@machty machty merged commit 0a00188 into main Sep 30, 2025
5 checks passed
@machty machty deleted the ember-tsc branch September 30, 2025 13:57
@github-actions github-actions bot mentioned this pull request Sep 30, 2025
@machty machty added the enhancement New feature or request label Sep 30, 2025
@ef4
Copy link
Contributor

ef4 commented Sep 30, 2025

The link above "new v2 upgrade instructions" doesn't go to instructions, I think perhaps it should be: https://github.com/typed-ember/glint/blob/main/docs/v2-upgrade.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants