Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sideeffffect
Copy link
Contributor

@sideeffffect sideeffffect commented Aug 31, 2021

Revival of #1126

Adds

  • a configuration case class that is suitable for PureConfig
  • helper method Config.makeHikariConfig for creating a com.zaxxer.hikari.HikariConfig
  • helper method HikariTransactor.fromConfig for creating a doobie.hikari.HikariTransactor

# Conflicts:
#	modules/hikari/src/main/scala/doobie/hikari/HikariTransactor.scala
@jatcwang
Copy link
Collaborator

@sideeffffect main is now CE3 so if you do need this in CE2 then you can target series/0.13.x, or you can update this PR to CE3 :)

@sideeffffect
Copy link
Contributor Author

The PR is based on main already. I just needed to fix the headers.

@sideeffffect
Copy link
Contributor Author

Oh, actually you're right 🤦 I've made the necessary Cats Effect 3 changes.

@jatcwang jatcwang self-assigned this Sep 1, 2021
@jatcwang jatcwang merged commit 68580b2 into typelevel:main Sep 1, 2021
@sideeffffect sideeffffect deleted the config branch September 1, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants