Migrate Test Suite to Munit with Cats Effect #2218
Conversation
|
@Sanskriti0805 , what is the reason of attaching |
the sbt-launch.jar file was mistakenly committed but has now been removed. Appreciate your guidance! |
No, it wasn't. Instead you added it to |
|
@Sanskriti0805 , the PR looks pretty good, thank you! |
|
hey @satorg Thanks a ton for all your help! 😊 |
|
|
||
| # sbt | ||
| .bsp/ | ||
| .bsp/ |
| val transactor: Resource[IO, HikariTransactor[IO]] = | ||
| for { | ||
| ce <- ExecutionContexts.fixedThreadPool[IO](16) // our connect EC | ||
| ce <- ExecutionContexts.fixedThreadPool[IO](16) // connect our EC |
There was a problem hiding this comment.
The original comment was correct, the change makes it incorrect
| } flatMap { case (n, ds) => | ||
| // One final report to show that all connections are disposed | ||
| report(ds) *> IO((n, ds.getHikariPoolMXBean.getTotalConnections)) | ||
|
|
| import doobie.* | ||
| import doobie.hikari.* | ||
| import doobie.implicits.* | ||
| import doobie.util.ExecutionContexts |
| test("HikariTransactor should close connections logically within `use` block and physically afterward.") { | ||
| assertEquals(prog.unsafeRunSync(), (0, 0)) | ||
| prog.assertEquals((0, 0)) | ||
|
|
There was a problem hiding this comment.
This looks good, just a style thing, we don't need the extra empty line :)
| val transactor: Resource[IO, HikariTransactor[IO]] = | ||
| for { | ||
| ce <- ExecutionContexts.fixedThreadPool[IO](16) // our connect EC | ||
| ce <- ExecutionContexts.fixedThreadPool[IO](16) // connect our EC |
There was a problem hiding this comment.
The original comment here makes sense, because with doobie we have a blocking ExecutionContext for awaiting for DB connections (i.e. the "connect EC")
Appreciate you trying to fix the comments though
There was a problem hiding this comment.
Thank you for the review and for pointing out the spurious changes! I understand now that some of the comment edits and small changes weren’t necessary. I’ll be more careful to limit future PRs to only meaningful changes and avoid unnecessary edits.
Appreciate you merging it regardless and taking the time to guide me! 🙌
Fixed the assertion method in the test acc to munits cat effect library