Scala 3 derivation - Switch to Mirror-based derivation #2242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch Scala 3 derivation to be based on macros instead of implicit
prioritization (MkWrite etc). For Scala 3 this improves compile times
significantly, as the `MkWrite/MkRead`-based derivation seems to be
evaluated differently by Scala 3 ("Implicit search problem too large").
- Move MkWrite/MkRead to Scala 2, as they're no longer needed in Scala 3
derivation implementation
- Remove fromPutOption/fromGetOption for both Scala 2 and 3 as it's
somewhat redundant whe we can get the same result via `Put[A] => Read[A]`, `Read[A] =>
Read[Option[A]]`.
Resolves #2214 #2241
jatcwang
commented
Apr 9, 2025
|
|
||
| trait LowerPriority2Write extends LowerPriority3Write { | ||
| implicit def fromPut[A](implicit put: Put[A]): Write[A] = | ||
| new Write.Single(put) |
There was a problem hiding this comment.
@satorg I removed fromPutOption / fromGetOption :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch Scala 3 derivation to be based on macros instead of implicit prioritization (MkWrite etc). For Scala 3 this improves compile times significantly, as the
MkWrite/MkRead-based derivation seems to be evaluated differently by Scala 3 ("Implicit search problem too large").Put[A] => Read[A],Read[A] => Read[Option[A]].Resolves #2214 #2241