Custom Exception instead of Validation Exception #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f8611af to
130c495
Compare
|
If you try to retain the previous behavior, you can use it like the following, use Tzsk\Payu\Exceptions\InvalidValueException;
...
try {
return Payu::initiate($transaction)->redirect(route('status'));
} catch (InvalidValueException $e) {
throw $e->validationException;
}This will throw the underlying validation exception and your code behavior will remain the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This package throws Laravel's
ValidationExceptionwhen it sees any invalid data in configuration or in the Payment Payload of any sort.A lot of Issues are being reported where devs are redirected back to the previous page because they are not catching validation exceptions. It is expected cause, that is the default behavior of Laravel for
ValidationException.This PR aims to throw an internal
InvalidValueExceptionwhich will be uncaught. So they will see the exception. They can easily catch this and generate the validation exception there after if they like.