[PLATFORM] Expand diagnostic types in tach upload#694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a change to the API contract between Tach and the Gauge platform.
It bumps the report version number from 1.4 to 1.5
The primary change is to skip mapping
DiagnosticsintoUsageError, and instead serializeDiagnosticsdirectly to JSON in full. The upside is this lets the platform independently add support for additional Diagnostic types one-by-one, but the downside is that Tach's representation ofDiagnosticsmust now be versioned. This PR adds a sanity check test that the structure of serialized Diagnostics has not changed, which should fail if Tach makes significant breaking changes to the schema.