Conversation
…s for local imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #599
This PR adds a 'rule' configuration option called
rules.local_imports. It can be set as usual:This rule applies to any Diagnostic that would have been emitted due to an import which is not at the global scope. This includes imports within 'if' statements, functions, classes, or other control structures.
The default setting is
"error", since today local imports are treated identically to global imports and will produce dependency/interface errors.Setting
local_imports = "off"means that you will no longer see Diagnostics for local imports, even when they violate dependency rules or public interfaces.