Fix unk.def in mecab-ipadic #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unknown symbols are not nouns. -POLM
|
Hello. This PR has been here for over a year, it would be great to have it addressed one way or another. I will add that I realized why the current setting is in place. There's a footnote in "Applying Conditional Random Fields to Japanese Morphological Analysis" that explains it:
While that sounds reasonable, the articles I linked above and the issue that has been linked to this PR since I originally posted it show that this setting causes confusion and I still think it should be changed. Any feedback at all would be appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github isn't showing the file properly, so to be clear, I changed this line:
to this:
The previous setting makes no sense and has confused many people. I guess it was a mistake?
The jumandic
unk.defdid not seem to have this problem.If there's anything I should improve, please let me know.
Many thanks for providing Mecab.