.github/workflows: ensure that create_release runs if we skip tests #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add logic to ensure that `create_release` is run if we are intentionally skipping tests. Updates #47 Signed-off-by: Mario Minardi <[email protected]>
mpminardi
commented
Feb 27, 2025
| # of the jobs is skipped. We must check that the result of `build_release` is | ||
| # "success" and that `test` is one of "success" or "skipped" as a result to ensure | ||
| # we are only creating a release when the `test` job has suceeded or been skipped. | ||
| if: always() && contains(needs.build_release.result, 'success') && (contains(needs.test.result, 'success') || contains(needs.test.result, 'skipped')) && contains(fromJSON('["push", "workflow_dispatch"]'), github.event_name) |
There was a problem hiding this comment.
See https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#needs-context for details on "needs context" syntax and allowed values.
bradfitz
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logic to ensure that
create_releaseis run if we are intentionally skipping tests.Updates #47