Do not add a beforeunload event listener when running inside NodeJS #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves this problem:
```
SHADOW import error /home/asp/projects/xxx/.shadow-cljs/builds/server/dev/out/cljs-runtime/taoensso.sente.js
/home/asp/projects/xxx/target/private/js/server.js:64
/* ignore this, look at stacktrace */ fn.call(global, require, module, __filename, __dirname);
^
TypeError: goog.global.addEventListener is not a function
at /home/asp/projects/xxx/.shadow-cljs/builds/server/dev/out/cljs-runtime/taoensso/sente.cljc:1353:4
at global.SHADOW_IMPORT (/home/asp/projects/xxx/target/private/js/server.js:64:44)
at /home/asp/projects/xxx/target/private/js/server.js:1624:1
at Object.<anonymous> (/home/asp/projects/xxx/target/private/js/server.js:1638:3)
at Module._compile (node:internal/modules/cjs/loader:1233:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1287:10)
at Module.load (node:internal/modules/cjs/loader:1091:32)
at Function.Module._load (node:internal/modules/cjs/loader:938:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
at node:internal/main/run_main_module:23:47
```
|
@theasp Thanks for this Andrew! Any urgency from your end for a new release, or could it wait a few weeks while I finish up some other stuff? |
|
Hi Peter, No urgency on my part, take your time. I didn't even notice for over a year! |
|
Merging manually now, thanks again Andrew! |
ptaoussanis
pushed a commit
that referenced
this pull request
Oct 28, 2024
…ing inside NodeJS (@theasp) This solves this problem: ``` SHADOW import error /home/asp/projects/xxx/.shadow-cljs/builds/server/dev/out/cljs-runtime/taoensso.sente.js /home/asp/projects/xxx/target/private/js/server.js:64 /* ignore this, look at stacktrace */ fn.call(global, require, module, __filename, __dirname); ^ TypeError: goog.global.addEventListener is not a function at /home/asp/projects/xxx/.shadow-cljs/builds/server/dev/out/cljs-runtime/taoensso/sente.cljc:1353:4 at global.SHADOW_IMPORT (/home/asp/projects/xxx/target/private/js/server.js:64:44) at /home/asp/projects/xxx/target/private/js/server.js:1624:1 at Object.<anonymous> (/home/asp/projects/xxx/target/private/js/server.js:1638:3) at Module._compile (node:internal/modules/cjs/loader:1233:14) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1287:10) at Module.load (node:internal/modules/cjs/loader:1091:32) at Function.Module._load (node:internal/modules/cjs/loader:938:12) at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12) at node:internal/main/run_main_module:23:47 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves this problem: