Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Overwrite the CameraGroup.optim_points function #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: (4->3) Add GUI Elements for Interacting With `RecordingSession`
merged 1 commit into from
Jul 3, 2024
Merged

Overwrite the CameraGroup.optim_points function #1845

merged 1 commit into from
Jul 3, 2024

Conversation

@roomrys
Copy link
Contributor

@roomrys roomrys commented Jul 3, 2024

Description

This PR is a quick fix to the fact that CameraGroup.optim_points from the aniposelib library does not handle nan values very well. The optim_points function is only called when we have a Skeleton with > 20 Nodes.

If upon triangulating, the user had some Points set as not visible (there are less than 2 visible labels for the same node), then we would get projections that look like so:
image

Overwriting the culprit CameraGroup.optim_points to simply pass through the 3D points instead of trying to optimize them yields the desired result:
image

And, when we double click, the non-visible node is initialized closeby:
image

This PR is just a quick fix to allow people to continue labeling with high-node skeletons until we get a PR (non-existent atm) merged into aniposelib to fix this issue at the source.

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

[list open issues here]

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

@coderabbitai
Copy link

coderabbitai bot commented Jul 3, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.10%. Comparing base (42ffe4e) to head (f85e2f6).

Files Patch % Lines
sleap/io/cameras.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@                           Coverage Diff                           @@
##           liezl/add-gui-elements-for-sessions    #1845      +/-   ##
=======================================================================
- Coverage                                74.10%   74.10%   -0.01%     
=======================================================================
  Files                                      135      135              
  Lines                                    25343    25345       +2     
=======================================================================
+ Hits                                     18781    18782       +1     
- Misses                                    6562     6563       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roomrys roomrys marked this pull request as ready for review July 3, 2024 04:39
@roomrys roomrys merged commit 475283d into liezl/add-gui-elements-for-sessions Jul 3, 2024
@roomrys roomrys deleted the liezl/quick-fix-optim-points branch July 3, 2024 04:42
@roomrys roomrys added the MultiView Stack This PR is part of the MultView stacked PRs. label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

MultiView Stack This PR is part of the MultView stacked PRs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@roomrys