Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add id property to RecordingSession #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: (4->3) Add GUI Elements for Interacting With `RecordingSession`
merged 4 commits into from
Jun 26, 2024
Merged

Add id property to RecordingSession #1829

merged 4 commits into from
Jun 26, 2024

Conversation

@roomrys
Copy link
Contributor

@roomrys roomrys commented Jun 25, 2024

Description

Previously, we used the hash of a RecordingSession as an ID in the Sessions Table. This PR adds a RecordingSession.id property that uses the index of the RecordingSession in the list of Labels.sessions if it exists (or reverts to the hash value).

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

[list open issues here]

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

@roomrys roomrys added the MultiView Stack This PR is part of the MultView stacked PRs. label Jun 25, 2024
@coderabbitai
Copy link

coderabbitai bot commented Jun 25, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Jun 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.11%. Comparing base (a5b4769) to head (154c46d).

Additional details and impacted files 
@@                         Coverage Diff                          @@
##           liezl/add-gui-elements-for-sessions    #1829   +/-   ##
====================================================================
  Coverage                                74.10%   74.11%           
====================================================================
  Files                                      135      135           
  Lines                                    25309    25314    +5     
====================================================================
+ Hits                                     18756    18761    +5     
  Misses                                    6553     6553

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roomrys roomrys marked this pull request as ready for review June 26, 2024 16:58
gitttt-1234
gitttt-1234 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@gitttt-1234 gitttt-1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed in subgroup, good to go

@gitttt-1234 gitttt-1234 merged commit a32d68a into liezl/add-gui-elements-for-sessions Jun 26, 2024
@roomrys roomrys deleted the liezl/add-id-property-to-session branch August 14, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gitttt-1234 gitttt-1234 gitttt-1234 approved these changes

Assignees

No one assigned

Labels

MultiView Stack This PR is part of the MultView stacked PRs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roomrys @gitttt-1234