Modify inference and centroid model to allow Bonsai ingestion #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #850 +/- ##
===========================================
+ Coverage 67.40% 67.59% +0.18%
===========================================
Files 130 130
Lines 22110 22187 +77
===========================================
+ Hits 14903 14997 +94
+ Misses 7207 7190 -17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roomrys
reviewed
Jul 21, 2022
tests/nn/test_inference.py
Outdated
Comment on lines
84
to
85
| @pytest.mark.skip | ||
| def test_save(model, preds, output_path): |
There was a problem hiding this comment.
Pytest will treat any function starting with test_ or ending with _test as a test. If you would like to define a helper function without it being considered a test, then renaming it works as well.
talmo
requested changes
Aug 23, 2022
| None | ||
| """ | ||
|
|
||
| predictor = load_model(model_path) |
There was a problem hiding this comment.
This (and the Predictor classmethod constructor a couple of calls down the stack) needs to have logic to handle centroid-only inputs and know to create a CentroidInferenceModel instead of a topdown one for ground truthing.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
Does this address any currently open issues?
[list open issues here]
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️