Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@roomrys
Copy link
Contributor

@roomrys roomrys commented Aug 1, 2022

Description

Previously, if

  1. an instance was created from a predicted instance with no track assigned,
  2. then a track was assigned to the new instance,
    the predicted instance would not be assigned the track.

This PR ensures that the linked predicted instance is assigned the same track as its linked counterpart.


Other minor fixes:

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

Assigning user instances to tracks unlinks them from predicted #866

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #879 (cbfbdd2) into develop (c62c8dc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #879   +/-   ##
========================================
  Coverage    66.69%   66.69%           
========================================
  Files          129      129           
  Lines        21728    21728           
========================================
+ Hits         14491    14492    +1     
+ Misses        7237     7236    -1     
Impacted Files Coverage Δ
sleap/gui/learning/runners.py 30.32% <ø> (-0.41%) ⬇️
sleap/instance.py 87.96% <ø> (ø)
sleap/gui/commands.py 58.61% <100.00%> (+0.13%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@roomrys roomrys marked this pull request as ready for review August 1, 2022 19:11
@roomrys roomrys requested a review from talmo August 1, 2022 19:11
Copy link
Collaborator

@talmo talmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@roomrys roomrys merged commit 1af563a into develop Aug 2, 2022
@roomrys roomrys deleted the liezl/add-new-track-to-linked-predicted branch August 2, 2022 16:25
@roomrys roomrys mentioned this pull request Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants