Thanks to visit codestin.com
Credit goes to github.com

Skip to content

M1 Mac support #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Aug 11, 2022
Merged

M1 Mac support #886

merged 32 commits into from
Aug 11, 2022

Conversation

@talmo
Copy link
Collaborator

@talmo talmo commented Aug 3, 2022 •
edited
Loading

Description

This PR adds M1 Mac support.

This is done through a combination of updating GUI dependencies and using custom TensorFlow distributions provided by Apple.

This PR also switches to using qtpy as a compatibility layer for different Qt-based GUI backends (Pyside2 or pyside6).

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

#579, #905

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

@codecov
Copy link

codecov bot commented Aug 3, 2022 •
edited
Loading

Codecov Report

Merging #886 (e2160c8) into develop (356c7ca) will decrease coverage by 0.96%.
The diff coverage is 14.13%.

@@             Coverage Diff             @@
##           develop     #886      +/-   ##
===========================================
- Coverage    68.30%   67.34%   -0.97%     
===========================================
  Files          129      130       +1     
  Lines        21753    22066     +313     
===========================================
+ Hits         14859    14860       +1     
- Misses        6894     7206     +312
Impacted Files Coverage Δ
sleap/diagnostic.py 0.00% <0.00%> (ø)
sleap/gui/overlays/anchors.py 0.00% <0.00%> (ø)
sleap/gui/suggestions.py 78.50% <0.00%> (ø)
sleap/gui/widgets/training_monitor.py 0.00% <0.00%> (ø)
sleap/instance.py 88.68% <ø> (+0.23%) ⬆️
sleap/io/visuals.py 90.81% <0.00%> (ø)
sleap/gui/overlays/confmaps.py 53.33% <50.00%> (ø)
sleap/gui/widgets/imagedir.py 77.27% <50.00%> (ø)
sleap/gui/widgets/video.py 66.39% <92.30%> (+0.20%) ⬆️
sleap/gui/app.py 76.73% <100.00%> (ø)
... and 25 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@talmo talmo marked this pull request as ready for review August 11, 2022 18:58
@talmo talmo merged commit 2efae3d into develop Aug 11, 2022
@roomrys roomrys mentioned this pull request Sep 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@talmo