Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@roomrys
Copy link
Contributor

@roomrys roomrys commented Aug 9, 2022

Description

Predictions were being incorrectly scaled when inference was run on videos of different resolutions. This PR ensures predictions are scaled correctly.

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #902 (2dcbeef) into develop (219a60f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #902   +/-   ##
========================================
  Coverage    68.30%   68.30%           
========================================
  Files          129      129           
  Lines        21754    21753    -1     
========================================
  Hits         14859    14859           
+ Misses        6895     6894    -1     
Impacted Files Coverage Δ
sleap/nn/data/resizing.py 65.77% <ø> (+0.43%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@roomrys roomrys marked this pull request as ready for review August 9, 2022 22:24
@roomrys roomrys requested a review from talmo August 9, 2022 22:25
Copy link
Collaborator

@talmo talmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I guess we were scaling the points twice?

@roomrys roomrys merged commit 356c7ca into develop Aug 10, 2022
@roomrys roomrys deleted the liezl/shifted-pred branch August 10, 2022 00:13
@roomrys roomrys mentioned this pull request Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants