Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Redraw plot to update trails after moving node #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2022
Merged

Redraw plot to update trails after moving node #910

merged 1 commit into from
Aug 12, 2022

Conversation

@roomrys
Copy link
Contributor

@roomrys roomrys commented Aug 12, 2022

Description

One line fix: redraw the plot after a QtNode.mouseReleaseEvent to update the trails.

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

Node trails don't update during proofreading #897

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #910 (27615df) into develop (2efae3d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #910      +/-   ##
===========================================
- Coverage    67.34%   67.34%   -0.01%     
===========================================
  Files          130      130              
  Lines        22066    22067       +1     
===========================================
  Hits         14860    14860              
- Misses        7206     7207       +1
Impacted Files Coverage Δ
sleap/gui/widgets/video.py 66.33% <0.00%> (-0.07%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roomrys roomrys marked this pull request as ready for review August 12, 2022 19:22
@roomrys roomrys requested a review from talmo August 12, 2022 19:22
talmo
talmo approved these changes Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@talmo talmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but double check that it doesn't hurt performance on long tracked videos?

@roomrys roomrys merged commit 73e3db0 into develop Aug 12, 2022
@roomrys roomrys deleted the liezl/update-trails branch August 12, 2022 23:29
@roomrys roomrys mentioned this pull request Sep 11, 2022
Merged
@roomrys roomrys mentioned this pull request Jan 19, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@talmo talmo talmo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roomrys @talmo