Force node to be placed w/in video #912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #912 +/- ##
===========================================
+ Coverage 67.34% 67.36% +0.02%
===========================================
Files 130 130
Lines 22067 22081 +14
===========================================
+ Hits 14860 14874 +14
Misses 7207 7207
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merged
|
An alternative approach would be being able to zoom out further than the player size and pan the video out of view, so any node that's outside can be easily grabbed anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Force nodes to be placed w/in video when dragging nodes in GUI.
Set coordinates of node to be within video even when mouse is dragged outside video. Note that this the video may be larger/smaller than the video player size (zoomed in/out video).
Types of changes
Does this address any currently open issues?
Labels (keypoints) go outside of the frame #896
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️