Fix logger widget vscode scrolling #3123

atharva-2001 · 2025-06-06T11:25:04Z

📝 Description

Type: 🪲 bugfix

Adds a scrollbar to the logger widget in vscode by wrapping the panel HTML in a panel Column object

📌 Resources

Examples, notebooks, and links to useful references.

Screen.Recording.2025-06-06.at.6.32.10.PM.mov

🚦 Testing

How did you test these changes?

Testing pipeline
Other method (describe)
My changes can't be tested (explain why)

☑️ Checklist

I requested two reviewers for this pull request
I updated the documentation according to my changes
I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

tardis-bot · 2025-06-06T11:26:27Z

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

tardis-bot · 2025-06-06T11:26:56Z

*beep* *bop*
Hi human,
I ran ruff on the latest commit (14799f0).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

6777	       	[ ] syntax-error
86	COM818 	[ ] trailing-comma-on-bare-tuple
64	W293   	[ ] blank-line-with-whitespace
25	W291   	[ ] trailing-whitespace
24	I001   	[*] unsorted-imports
23	F401   	[ ] unused-import
13	G004   	[ ] logging-f-string
11	W191   	[ ] tab-indentation
10	W605   	[*] invalid-escape-sequence
 9	RET505 	[*] superfluous-else-return
 6	E402   	[ ] module-import-not-at-top-of-file
 5	E902   	[ ] io-error
 5	F405   	[ ] undefined-local-with-import-star-usage
 4	W292   	[*] missing-newline-at-end-of-file
 4	D204   	[*] incorrect-blank-line-after-class
 4	F811   	[ ] redefined-while-unused
 4	F821   	[ ] undefined-name
 4	UP015  	[*] redundant-open-modes
 3	D202   	[*] blank-line-after-function
 3	NPY201 	[ ] numpy2-deprecation
 2	PGH004 	[ ] blanket-noqa
 2	RET506 	[*] superfluous-else-raise
 1	E701   	[ ] multiple-statements-on-one-line-colon
 1	E712   	[ ] true-false-comparison
 1	E722   	[ ] bare-except
 1	B019   	[ ] cached-instance-method
 1	D411   	[*] no-blank-line-before-section
 1	F403   	[ ] undefined-local-with-import-star
 1	PLW0127	[ ] self-assigning-variable
 1	RUF015 	[ ] unnecessary-iterable-allocation-for-first-element
 1	RUF021 	[*] parenthesize-chained-operators
 1	TRY300 	[ ] try-consider-else
 1	UP009  	[*] utf8-encoding-declaration
 1	UP030  	[ ] format-literals
 1	UP032  	[*] f-string
Found 7101 errors.
[*] 133 fixable with the `--fix` option (29 hidden fixes can be enabled with the `--unsafe-fixes` option).

Complete output(might be large):

benchmarks/spectrum_formal_integral.py:5:1: I001 [*] Import block is un-sorted or un-formatted
benchmarks/spectrum_formal_integral.py:24:5: B019 Use of `functools.lru_cache` or `functools.cache` on methods can lead to memory leaks
benchmarks/spectrum_formal_integral.py:43:52: W291 [*] Trailing whitespace
benchmarks/spectrum_formal_integral.py:45:45: W291 [*] Trailing whitespace
benchmarks/spectrum_formal_integral.py:46:42: W291 [*] Trailing whitespace
docs/conf.py:1:1: UP009 [*] UTF-8 encoding declaration is unnecessary
docs/conf.py:27:1: I001 [*] Import block is un-sorted or un-formatted
docs/conf.py:30:8: F401 [*] `tardis` imported but unused
docs/conf.py:37:43: PGH004 Use specific rule codes when using `noqa`
docs/conf.py:47:27: UP015 [*] Unnecessary mode argument
docs/conf.py:68:1: F405 `exclude_patterns` may be undefined, or defined from star imports
docs/conf.py:69:1: F405 `exclude_patterns` may be undefined, or defined from star imports
docs/conf.py:70:1: F405 `exclude_patterns` may be undefined, or defined from star imports
docs/conf.py:71:1: F405 `exclude_patterns` may be undefined, or defined from star imports
docs/conf.py:72:1: F405 `exclude_patterns` may be undefined, or defined from star imports
docs/conf.py:140:1: W293 Blank line contains whitespace
docs/conf.py:175:1: W293 Blank line contains whitespace
docs/conf.py:192:13: UP030 Use implicit references for positional format fields
docs/conf.py:192:13: UP032 [*] Use f-string instead of `format` call
docs/conf.py:219:1: E402 Module level import not at top of file
docs/conf.py:291:4: E712 Avoid equality comparisons to `True`; use `toml_config_tool_dict["tardis"]['edit_on_github']:` for truth checks
docs/conf.py:313:1: E402 Module level import not at top of file
docs/conf.py:365:1: E402 Module level import not at top of file
docs/conf.py:380:37: UP015 [*] Unnecessary modes, use `w`
docs/conf.py:395:41: UP015 [*] Unnecessary modes, use `w`
docs/conf.py:410:37: UP015 [*] Unnecessary modes, use `w`
tardis/base.py:106:13: PLW0127 Self-assignment of variable `atom_data`
tardis/conftest.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/conftest.py:12:1: F403 `from tardis.tests.fixtures.atom_data import *` used; unable to detect undefined names
tardis/conftest.py:15:36: F401 [*] `tardis.tests.test_util.monkeysession` imported but unused
tardis/conftest.py:18:12: F401 `tardisbase` imported but unused; consider using `importlib.util.find_spec` to test for availability
tardis/conftest.py:39:49: PGH004 Use specific rule codes when using `noqa`
tardis/conftest.py:41:9: F821 Undefined name `pytest_report_header`
tardis/io/logger/logger.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/logger/logger.py:4:17: F401 [*] `panel` imported but unused
tardis/io/logger/logger.py:6:18: F401 [*] `pandas` imported but unused
tardis/io/logger/logger.py:19:5: D204 [*] 1 blank line required after class docstring
tardis/io/logger/logger.py:20:1: W293 Blank line contains whitespace
tardis/io/logger/logger.py:56:5: D204 [*] 1 blank line required after class docstring
tardis/io/logger/logger.py:57:1: W293 Blank line contains whitespace
tardis/io/logger/logger.py:75:1: W293 Blank line contains whitespace
tardis/io/logger/logger.py:84:1: W293 Blank line contains whitespace
tardis/io/logger/logger.py:99:21: G004 Logging statement uses f-string
tardis/io/logger/logger.py:161:1: W293 Blank line contains whitespace
tardis/io/logger/logger.py:173:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger.py:178:75: W291 [*] Trailing whitespace
tardis/io/logger/logger.py:182:80: W291 [*] Trailing whitespace
tardis/io/logger/logger.py:185:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger.py:192:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger.py:198:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger.py:203:5: D204 [*] 1 blank line required after class docstring
tardis/io/logger/logger.py:204:1: W293 Blank line contains whitespace
tardis/io/logger/logger.py:215:1: W293 Blank line contains whitespace
tardis/io/logger/logger.py:220:1: W293 Blank line contains whitespace
tardis/io/logger/logger.py:230:1: W293 Blank line contains whitespace
tardis/io/logger/logger.py:247:1: W293 Blank line contains whitespace
tardis/io/logger/logger.py:257:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger.py:265:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger.py:280:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger.py:283:5: RET505 [*] Unnecessary `else` after `return` statement
tardis/io/logger/logger_widget.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/io/logger/logger_widget.py:13:1: W293 Blank line contains whitespace
tardis/io/logger/logger_widget.py:21:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger_widget.py:41:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger_widget.py:46:5: D204 [*] 1 blank line required after class docstring
tardis/io/logger/logger_widget.py:47:1: W293 Blank line contains whitespace
tardis/io/logger/logger_widget.py:66:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger_widget.py:69:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger_widget.py:77:1: W293 Blank line contains whitespace
tardis/io/logger/logger_widget.py:101:1: W293 Blank line contains whitespace
tardis/io/logger/logger_widget.py:106:1: W293 Blank line contains whitespace
tardis/io/logger/logger_widget.py:117:1: W293 Blank line contains whitespace
tardis/io/logger/logger_widget.py:124:1: W293 Blank line contains whitespace
tardis/io/logger/logger_widget.py:139:1: W293 Blank line contains whitespace
tardis/io/logger/logger_widget.py:149:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger_widget.py:152:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger_widget.py:157:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger_widget.py:159:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger_widget.py:164:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger_widget.py:168:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger_widget.py:171:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger_widget.py:178:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger_widget.py:180:115: W291 [*] Trailing whitespace
tardis/io/logger/logger_widget.py:183:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger_widget.py:186:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger_widget.py:189:1: W293 Blank line contains whitespace
tardis/io/logger/logger_widget.py:202:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger_widget.py:208:1: W293 [*] Blank line contains whitespace
tardis/io/logger/logger_widget.py:216:1: W293 [*] Blank line contains whitespace
tardis/simulation/base.py:245:17: G004 Logging statement uses f-string
tardis/simulation/base.py:418:13: G004 Logging statement uses f-string
tardis/simulation/base.py:519:13: G004 Logging statement uses f-string
tardis/simulation/base.py:599:13: G004 Logging statement uses f-string
tardis/simulation/base.py:604:13: G004 Logging statement uses f-string
tardis/simulation/base.py:655:13: TRY300 Consider moving this statement to an `else` block
tardis/simulation/base.py:657:26: G004 Logging statement uses f-string
tardis/spectrum/formal_integral/base.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/base.py:38:9: RET506 [*] Unnecessary `else` after `raise` statement
tardis/spectrum/formal_integral/base.py:108:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/base.py:113:5: D411 [*] Missing blank line before section ("Parameters")
tardis/spectrum/formal_integral/base.py:281:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/base.py:307:1: W293 [*] Blank line contains whitespace
tardis/spectrum/formal_integral/formal_integral.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/formal_integral.py:4:31: F401 [*] `scipy.interpolate.interp1d` imported but unused
tardis/spectrum/formal_integral/formal_integral.py:10:55: F401 [*] `tardis.transport.montecarlo.configuration.montecarlo_globals` imported but unused
tardis/spectrum/formal_integral/formal_integral.py:136:1: W293 [*] Blank line contains whitespace
tardis/spectrum/formal_integral/formal_integral.py:143:94: W291 [*] Trailing whitespace
tardis/spectrum/formal_integral/formal_integral_cuda.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/formal_integral_cuda.py:73:5: RET505 [*] Unnecessary `else` after `return` statement
tardis/spectrum/formal_integral/formal_integral_cuda.py:112:5: RET505 [*] Unnecessary `else` after `return` statement
tardis/spectrum/formal_integral/formal_integral_cuda.py:537:8: W292 [*] No newline at end of file
tardis/spectrum/formal_integral/formal_integral_numba.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/formal_integral_numba.py:24:5: RET505 [*] Unnecessary `else` after `return` statement
tardis/spectrum/formal_integral/formal_integral_numba.py:54:5: RET505 [*] Unnecessary `else` after `return` statement
tardis/spectrum/formal_integral/formal_integral_numba.py:129:12: NPY201 `np.trapz` will be removed in NumPy 2.0. Use `numpy.trapezoid` on NumPy 2.0, or ignore this warning on earlier versions.
tardis/spectrum/formal_integral/formal_integral_numba.py:353:10: W292 [*] No newline at end of file
tardis/spectrum/formal_integral/formal_integral_solver.py:1:1: E902 No such file or directory (os error 2)
tardis/spectrum/formal_integral/source_function.py:1:1: E902 No such file or directory (os error 2)
tardis/spectrum/formal_integral/tests/test_cuda_formal_integral.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/tests/test_cuda_formal_integral.py:385:55: W292 [*] No newline at end of file
tardis/spectrum/formal_integral/tests/test_formal_integral.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/tests/test_formal_integral.py:7:55: F401 [*] `tardis.transport.montecarlo.configuration.montecarlo_globals` imported but unused
tardis/spectrum/formal_integral/tests/test_formal_integral.py:13:27: F401 [*] `tardis.spectrum.formal_integral.formal_integral_cuda.calculate_p_values` imported but unused
tardis/spectrum/formal_integral/tests/test_formal_integral.py:14:5: F401 [*] `tardis.spectrum.formal_integral.formal_integral_cuda.intensity_black_body_cuda` imported but unused
tardis/spectrum/formal_integral/tests/test_formal_integral.py:18:33: W291 [*] Trailing whitespace
tardis/spectrum/formal_integral/tests/test_formal_integral.py:19:27: W291 [*] Trailing whitespace
tardis/spectrum/formal_integral/tests/test_formal_integral.py:20:26: W291 [*] Trailing whitespace
tardis/spectrum/formal_integral/tests/test_formal_integral.py:56:26: W291 [*] Trailing whitespace
tardis/spectrum/formal_integral/tests/test_numba_formal_integral.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/tests/test_numba_formal_integral.py:8:61: F401 [*] `tardis.spectrum.formal_integral.formal_integral.FormalIntegrator` imported but unused
tardis/spectrum/formal_integral/tests/test_numba_formal_integral.py:45:16: NPY201 `np.trapz` will be removed in NumPy 2.0. Use `numpy.trapezoid` on NumPy 2.0, or ignore this warning on earlier versions.
tardis/spectrum/formal_integral/tests/test_source_function.py:1:1: E902 No such file or directory (os error 2)
tardis/tests/test_tardis_full_formal_integral.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/util/base.py:185:20: NPY201 `np.trapz` will be removed in NumPy 2.0. Use `numpy.trapezoid` on NumPy 2.0, or ignore this warning on earlier versions.
tardis/util/base.py:336:5: RET505 [*] Unnecessary `else` after `return` statement
tardis/util/base.py:510:5: E722 Do not use bare `except`
tardis/util/environment.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/util/environment.py:8:28: W291 [*] Trailing whitespace
tardis/util/environment.py:13:1: W293 [*] Blank line contains whitespace
tardis/util/environment.py:17:1: W293 Blank line contains whitespace
tardis/util/environment.py:25:9: RET505 [*] Unnecessary `elif` after `return` statement
tardis/util/environment.py:34:1: W293 [*] Blank line contains whitespace
tardis/util/environment.py:41:1: W293 [*] Blank line contains whitespace
tardis/util/environment.py:48:1: W293 [*] Blank line contains whitespace
tardis/util/environment.py:61:1: W293 [*] Blank line contains whitespace
tardis/util/environment.py:74:9: RET505 [*] Unnecessary `elif` after `return` statement
tardis/util/environment.py:83:1: W293 Blank line contains whitespace
tardis/util/panel_init.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/util/panel_init.py:10:92: W291 [*] Trailing whitespace
tardis/util/panel_init.py:42:1: W293 [*] Blank line contains whitespace
tardis/visualization/__init__.py:3:1: I001 [*] Import block is un-sorted or un-formatted
tardis/visualization/__init__.py:3:57: F401 `tardis.visualization.tools.convergence_plot.ConvergencePlots` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/visualization/__init__.py:4:49: F401 `tardis.visualization.tools.liv_plot.LIVPlotter` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/visualization/__init__.py:5:53: F401 `tardis.visualization.tools.rpacket_plot.RPacketPlotter` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/visualization/__init__.py:6:50: F401 `tardis.visualization.tools.sdec_plot.SDECPlotter` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/visualization/__init__.py:7:59: F401 `tardis.visualization.widgets.custom_abundance.CustomAbundanceWidget` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/visualization/__init__.py:8:51: F401 `tardis.visualization.widgets.grotrian.GrotrianWidget` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/visualization/__init__.py:9:52: F401 `tardis.visualization.widgets.line_info.LineInfoWidget` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/visualization/__init__.py:11:5: F401 `tardis.visualization.widgets.shell_info.shell_info_from_hdf` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/visualization/__init__.py:12:5: F401 `tardis.visualization.widgets.shell_info.shell_info_from_simulation` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
tardis/visualization/__init__.py:17:1: E402 Module level import not at top of file
tardis/visualization/__init__.py:17:1: I001 [*] Import block is un-sorted or un-formatted
tardis/visualization/__init__.py:18:36: W292 [*] No newline at end of file
tardis/visualization/tools/tests/test_convergence_plot.py:3:1: I001 [*] Import block is un-sorted or un-formatted
tardis/visualization/tools/tests/test_convergence_plot.py:14:25: F811 [*] Redefinition of unused `defaultdict` from line 3
tardis/visualization/tools/tests/test_convergence_plot.py:15:32: F811 [*] Redefinition of unused `go` from line 6
tardis/visualization/tools/tests/test_convergence_plot.py:16:30: F811 [*] Redefinition of unused `u` from line 8
tardis/visualization/widgets/custom_abundance.py:737:16: RUF021 [*] Parenthesize `a and b` expressions when chaining `and` and `or` together, to make the precedence clear
tardis/visualization/widgets/custom_abundance.py:1127:9: RET505 [*] Unnecessary `else` after `return` statement
tardis/visualization/widgets/custom_abundance.py:1418:9: RET506 [*] Unnecessary `else` after `raise` statement
tardis/visualization/widgets/custom_abundance.py:1721:9: F811 Redefinition of unused `input_d_time_0_eventhandler` from line 1710
tardis/visualization/widgets/custom_abundance.py:1751:13: F821 Undefined name `display`
tardis/visualization/widgets/custom_abundance.py:1753:13: F821 Undefined name `display`
tardis/visualization/widgets/custom_abundance.py:1755:13: F821 Undefined name `display`
tardis/visualization/widgets/line_info.py:3:1: I001 [*] Import block is un-sorted or un-formatted
tardis/visualization/widgets/line_info.py:450:1: W293 [*] Blank line contains whitespace
tardis/visualization/widgets/line_info.py:454:1: W293 [*] Blank line contains whitespace
tardis/visualization/widgets/line_info.py:458:1: W293 [*] Blank line contains whitespace
tardis/visualization/widgets/line_info.py:462:1: W293 [*] Blank line contains whitespace
tardis/visualization/widgets/line_info.py:467:1: W293 [*] Blank line contains whitespace
tardis/visualization/widgets/line_info.py:476:1: W293 [*] Blank line contains whitespace
tardis/visualization/widgets/line_info.py:531:1: W293 [*] Blank line contains whitespace
tardis/visualization/widgets/line_info.py:715:1: W293 [*] Blank line contains whitespace
tardis/visualization/widgets/tests/test_custom_abundance.py:224:37: RUF015 Prefer `next(iter(unique_v))` over single element slice
tardis/visualization/widgets/tests/test_line_info.py:9:1: E402 Module level import not at top of file
tardis/visualization/widgets/tests/test_shell_info.py:6:1: E402 Module level import not at top of file
tardis/workflows/simple_tardis_workflow.py:249:17: G004 Logging statement uses f-string
tardis/workflows/simple_tardis_workflow.py:466:17: G004 Logging statement uses f-string
tardis/workflows/standard_tardis_workflow.py:169:13: G004 Logging statement uses f-string
tardis/workflows/standard_tardis_workflow.py:209:17: G004 Logging statement uses f-string
tardis/workflows/tests/__init__.py:1:1: E902 No such file or directory (os error 2)
tardis/workflows/tests/test_workflows.py:1:1: E902 No such file or directory (os error 2)
tardis/workflows/workflow_logging.py:69:13: G004 Logging statement uses f-string
tardis/workflows/workflow_logging.py:107:21: G004 Logging statement uses f-string
Found 194 errors.
[*] 114 fixable with the `--fix` option (29 hidden fixes can be enabled with the `--unsafe-fixes` option).

codecov · 2025-06-06T11:43:10Z

Codecov Report

❌ Patch coverage is 75.00000% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.00%. Comparing base (536821c) to head (14799f0).
⚠️ Report is 11 commits behind head on master.

Files with missing lines	Patch %	Lines
tardis/io/logger/logger_widget.py	77.65%	21 Missing ⚠️
tardis/util/panel_init.py	51.35%	18 Missing ⚠️
tardis/util/environment.py	79.24%	11 Missing ⚠️
tardis/io/logger/logger.py	78.94%	8 Missing ⚠️
tardis/base.py	0.00%	1 Missing ⚠️
tardis/workflows/standard_tardis_workflow.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3123      +/-   ##
==========================================
+ Coverage   71.88%   74.00%   +2.11%     
==========================================
  Files         246      252       +6     
  Lines       17250    17549     +299     
==========================================
+ Hits        12401    12987     +586     
+ Misses       4849     4562     -287

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tardis-bot · 2025-06-06T12:49:16Z

*beep* *bop*
Hi human,
I ran benchmarks as you asked comparing master (536821c) and the latest commit (1508fd5).
Here are the logs produced by ASV.
Results can also be downloaded as artifacts here.

Significantly changed benchmarks:

All benchmarks:

Benchmarks that have stayed the same:

| Change   | Before [536821c0] <master>   | After [1508fd5d]    | Ratio   | Benchmark (Parameter)                                                                                                               |
|----------|------------------------------|---------------------|---------|-------------------------------------------------------------------------------------------------------------------------------------|
|          | 501±200ns                    | 882±100ns           | ~1.76   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation                                      |
|          | 43.1±30μs                    | 54.3±20μs           | ~1.26   | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter                                          |
|          | 40.5±20μs                    | 48.1±20μs           | ~1.19   | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission                                         |
|          | 492±200ns                    | 561±100ns           | ~1.14   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation                              |
|          | 23.9±6μs                     | 21.3±5μs            | ~0.89   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list |
|          | 3.63±0.2μs                   | 3.16±0.4μs          | ~0.87   | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket                                       |
|          | 1.59±6μs                     | 1.34±0.3μs          | ~0.84   | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line                    |
|          | 2.95±0.8μs                   | 2.47±0.5μs          | ~0.84   | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell                              |
|          | 2.08±2μs                     | 2.26±1μs            | 1.08    | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators       |
|          | 2.65±0.3ms                   | 2.73±0.3ms          | 1.03    | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop                        |
|          | 551±200ns                    | 562±100ns           | 1.02    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation                                |
|          | 3.73±0.02ms                  | 3.80±0.01ms         | 1.02    | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom')                                   |
|          | 39.4±0.02μs                  | 40.2±0.01μs         | 1.02    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list                  |
|          | 6.87±2μs                     | 7.00±2μs            | 1.02    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley                                    |
|          | 193±0.3ns                    | 196±0.5ns           | 1.01    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body                                       |
|          | 59.5±0.2ms                   | 60.2±0.06ms         | 1.01    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe                  |
|          | 2.10±0m                      | 2.11±0m             | 1.00    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions                                 |
|          | 1.14±0.01μs                  | 1.13±0μs            | 1.00    | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary                |
|          | 2.54±0.02ms                  | 2.55±0.01ms         | 1.00    | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop                             |
|          | 1.06±0m                      | 1.04±0m             | 0.98    | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking                                                                      |
|          | 38.2±0.1s                    | 37.1±0.09s          | 0.97    | run_tardis.BenchmarkRunTardis.time_run_tardis                                                                                       |
|          | 690±0.3ns                    | 669±0.8ns           | 0.97    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter                                       |
|          | 3.05±0.02ms                  | 2.82±0.02ms         | 0.93    | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter')                                     |
|          | 7.00±5μs                     | 6.38±1μs            | 0.91    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket                                           |

If you want to see the graph of the results, you can check it here

Copilot

Pull Request Overview

This PR fixes the scrolling issue in the VS Code logger widget by wrapping the HTML pane in a Panel Column and updating the logger output access.

Updates create_output_widget to return a pn.Column containing an HTML pane with scroll enabled.
Adjusts _emit_to_widget to access log output elements via an index, reflecting a new data structure.

Comments suppressed due to low confidence (2)

tardis/io/logger/logger.py:235

Ensure that self.log_outputs[output_key] consistently contains at least one element before accessing index 0 to avoid potential runtime errors.

current = self.log_outputs[output_key][0].object or ""

tardis/io/logger/logger.py:239

Confirm that the 'ALL' entry in self.log_outputs reliably contains a list with at least one item, as the new indexing approach relies on this structure.

self.log_outputs["ALL"][0].object = current_all + "\n" + html_wrapped if current_all else html_wrapped

wkerzendorf · 2025-06-07T20:41:27Z

@atharva-2001 doesn't work for me - but we can talk about it together.

tardis-bot · 2025-06-10T12:20:50Z

*beep* *bop*

Hi, human.

I'm the @tardis-bot and I noticed that your email is not associated with an ORCID ID in our database.

Please add your email and ORCID ID to the .orcid.csv file in your current branch and push the changes to this pull request.

If you don't have an ORCID ID yet, you can create one for free at orcid.org. ORCID IDs help ensure you get proper credit for your scientific contributions.

The format should be:

email,orcid
[email protected],0000-0000-0000-0000

wkerzendorf · 2025-06-16T14:22:41Z

add logger_widget.py file

wkerzendorf · 2025-06-16T14:12:40Z

docs/conf.py


+_notebook_start_time = {}
+
+def nbsphinx_notebook_start(app, env, docnames):


please remove

wkerzendorf · 2025-06-16T14:15:26Z

tardis/io/logger/logger.py

+            sizing_mode='stretch_width'
+        )
+        column.max_log_entries = 1000
+        column._start_height = 10


expose variables start_height and max_height

tardis/io/logger/logger.py

tardis/util/environment.py

tardis/io/logger/logger.py

tardis/util/environment.py

review-notebook-app · 2025-07-31T15:10:13Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jvshields · 2025-08-12T15:35:01Z

tardis/visualization/__init__.py

 )
+
+
+print("Initializing tabulator and plotly panel extensions for widgets to work")


Should we get rid of this before merging? It's a bit informal.

jvshields

It works well enough that I'm fine to merge this. I still see faint grey text that makes me think I can basically everything in the logger, but maybe we're not trying to fix that here.

Also I left a comment about the message printed out that I'd like to see removed or at least changed to something a bit better, but it's not the hugest deal.

atharva-2001 changed the title ~~wrap html in panel column~~ Fix logger widget vscode scrolling Jun 6, 2025

atharva-2001 marked this pull request as ready for review June 6, 2025 11:38

atharva-2001 added the build-docs label Jun 6, 2025

wkerzendorf requested a review from Copilot June 6, 2025 14:41

Copilot AI reviewed Jun 6, 2025

View reviewed changes

atharva-2001 force-pushed the logger_widget_vscode_scroll branch from ea4b38e to 18df225 Compare June 11, 2025 11:48

wkerzendorf reviewed Jun 16, 2025

View reviewed changes

atharva-2001 commented Jun 17, 2025

View reviewed changes

tardis/util/environment.py Outdated Show resolved Hide resolved

atharva-2001 commented Jun 17, 2025

View reviewed changes

tardis/io/logger/logger.py Outdated Show resolved Hide resolved

atharva-2001 marked this pull request as draft June 30, 2025 14:18

atharva-2001 marked this pull request as ready for review July 8, 2025 12:54

atharva-2001 force-pushed the logger_widget_vscode_scroll branch from d70169e to ec135d2 Compare July 11, 2025 13:37

wkerzendorf reviewed Jul 15, 2025

View reviewed changes

tardis/util/environment.py Outdated Show resolved Hide resolved

atharva-2001 mentioned this pull request Jul 25, 2025

Remove qgridnext #3197

Merged

6 tasks

atharva-2001 added 9 commits July 31, 2025 16:15

wrap html in panel column

f59238d

separate widgets based on log levels

1663990

embed using display handles

de71e80

display handler

dcfad97

test notebook logging in sphinx

7568dd0

embed after simulation completes

3f5ef9b

try batch updating

7eb7981

try string concat

47b9c2b

remove batch update and github actions check

7dbf692

atharva-2001 added 11 commits July 31, 2025 16:15

is notebook patch

0f8ad98

minor cleanup

8e318ca

old nbsphinx argument

f6926db

is_vscode is cleaner

6672c1e

check env

0694011

vscode cmd

57443a1

typo fix

7df677c

use moria in notebook places

c7f77de

better environment detection

eac78d9

is moria or is vscode

68dedb8

Remove moria

d547ad3

atharva-2001 force-pushed the logger_widget_vscode_scroll branch from 3f76280 to d547ad3 Compare July 31, 2025 10:47

atharva-2001 added 5 commits July 31, 2025 16:40

remove title fix convergence plot logic

86239df

allow other widgets to display similarly

5bce1bd

collab comms to ipywidget comms

e0070cd

batch logs

4dd57f8

add the extensions to the init file and remove from the cell

1508fd5

andrewfullard approved these changes Jul 31, 2025

View reviewed changes

andrewfullard previously approved these changes Jul 31, 2025

View reviewed changes

andrewfullard requested a review from wkerzendorf July 31, 2025 18:23

andrewfullard mentioned this pull request Jul 31, 2025

Refactor progress bar handling and improve convergence plot updates #3183

Merged

atharva-2001 mentioned this pull request Aug 1, 2025

Logger Widget Refactor #3062

Closed

6 tasks

single column

14799f0

atharva-2001 dismissed andrewfullard’s stale review via 14799f0 August 12, 2025 10:50

andrewfullard self-requested a review August 12, 2025 13:13

andrewfullard approved these changes Aug 12, 2025

View reviewed changes

jvshields reviewed Aug 12, 2025

View reviewed changes

jvshields approved these changes Aug 12, 2025

View reviewed changes

andrewfullard merged commit c7ad4e8 into tardis-sn:master Aug 12, 2025
21 of 24 checks passed


		_notebook_start_time = {}

		def nbsphinx_notebook_start(app, env, docnames):

		)


		print("Initializing tabulator and plotly panel extensions for widgets to work")

Uh oh!

Fix logger widget vscode scrolling #3123

Fix logger widget vscode scrolling #3123

Uh oh!

Conversation

atharva-2001 commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

📌 Resources

🚦 Testing

☑️ Checklist

Uh oh!

tardis-bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tardis-bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tardis-bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

wkerzendorf commented Jun 7, 2025

Uh oh!

tardis-bot commented Jun 10, 2025

Uh oh!

wkerzendorf commented Jun 16, 2025

Uh oh!

wkerzendorf Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

wkerzendorf Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

review-notebook-app bot commented Jul 31, 2025

Uh oh!

jvshields Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

jvshields left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

atharva-2001 commented Jun 6, 2025 •

edited

Loading

tardis-bot commented Jun 6, 2025 •

edited

Loading

tardis-bot commented Jun 6, 2025 •

edited

Loading

codecov bot commented Jun 6, 2025 •

edited

Loading

tardis-bot commented Jun 6, 2025 •

edited

Loading

jvshields left a comment •

edited

Loading