Viz modules `from_workflow` tests #3277

atharva-2001 · 2025-09-01T12:11:43Z

📝 Description

Tests the from_workflow method in the SDEC plot and the liv plot using the existing regression data.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

Testing pipeline
Other method (describe)
My changes can't be tested (explain why)

☑️ Checklist

I requested two reviewers for this pull request
I updated the documentation according to my changes
I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

tardis-bot · 2025-09-01T12:13:27Z

*beep* *bop*

Hi, human.

I'm the @tardis-bot and I noticed that your email is not associated with an ORCID ID in our database.

Please add your email and ORCID ID to the .orcid.csv file in your current branch and push the changes to this pull request.

If you don't have an ORCID ID yet, you can create one for free at orcid.org. ORCID IDs help ensure you get proper credit for your scientific contributions.

The format should be:

email,orcid
[email protected],0000-0000-0000-0000

tardis-bot · 2025-09-01T12:14:04Z

*beep* *bop*
Hi human,
I ran ruff on the latest commit (083d089).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

7622	      	[ ] syntax-error
40	W293  	[ ] blank-line-with-whitespace
17	F401  	[ ] unused-import
17	I001  	[*] unsorted-imports
 8	G004  	[ ] logging-f-string
 6	W291  	[ ] trailing-whitespace
 5	RET505	[*] superfluous-else-return
 3	E701  	[ ] multiple-statements-on-one-line-colon
 3	D202  	[*] blank-line-after-function
 3	RET506	[*] superfluous-else-raise
 2	E402  	[ ] module-import-not-at-top-of-file
 2	E902  	[ ] io-error
 2	W292  	[ ] missing-newline-at-end-of-file
 2	ISC003	[*] explicit-string-concatenation
 2	NPY201	[ ] numpy2-deprecation
 1	ANN204	[ ] missing-return-type-special-method
 1	B018  	[ ] useless-expression
 1	D406  	[*] missing-new-line-after-section-name
 1	D407  	[*] missing-dashed-underline-after-section
 1	F403  	[ ] undefined-local-with-import-star
 1	F811  	[ ] redefined-while-unused
 1	F821  	[ ] undefined-name
 1	PGH004	[ ] blanket-noqa
 1	TRY300	[ ] try-consider-else
Found 7743 errors.
[*] 86 fixable with the `--fix` option (3 hidden fixes can be enabled with the `--unsafe-fixes` option).

Complete output(might be large):

tardis/conftest.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/conftest.py:13:1: F403 `from tardis.tests.fixtures.atom_data import *` used; unable to detect undefined names
tardis/conftest.py:18:36: F401 [*] `tardis.tests.test_util.monkeysession` imported but unused
tardis/conftest.py:21:12: F401 `tardisbase` imported but unused; consider using `importlib.util.find_spec` to test for availability
tardis/conftest.py:42:49: PGH004 Use specific rule codes when using `noqa`
tardis/conftest.py:44:9: F821 Undefined name `pytest_report_header`
tardis/conftest.py:314:1: W293 [*] Blank line contains whitespace
tardis/opacities/macro_atom/macroatom_transitions.py:18:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/opacities/opacity_state.py:110:9: ANN204 Missing return type annotation for special method `__getitem__`
tardis/opacities/opacity_state.py:116:9: D407 [*] Missing dashed underline after section ("Returns")
tardis/opacities/opacity_state.py:116:9: D406 [*] Section name should end with a newline ("Returns")
tardis/opacities/opacity_state.py:245:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/opacities/tests/test_opacity_state_numba.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/opacities/tests/test_opacity_state_numba.py:2:44: F401 [*] `tardis.opacities.opacity_state.OpacityState` imported but unused
tardis/plasma/equilibrium/tests/test_ion_populations.py:5:8: F401 [*] `pytest` imported but unused
tardis/simulation/base.py:262:17: G004 Logging statement uses f-string
tardis/simulation/base.py:445:13: G004 Logging statement uses f-string
tardis/simulation/base.py:552:13: G004 Logging statement uses f-string
tardis/simulation/base.py:645:13: G004 Logging statement uses f-string
tardis/simulation/base.py:650:13: G004 Logging statement uses f-string
tardis/simulation/base.py:701:13: TRY300 Consider moving this statement to an `else` block
tardis/simulation/base.py:703:26: G004 Logging statement uses f-string
tardis/spectrum/formal_integral/base.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/base.py:3:24: F401 [*] `scipy.sparse` imported but unused
tardis/spectrum/formal_integral/base.py:4:31: F401 [*] `scipy.sparse.linalg` imported but unused
tardis/spectrum/formal_integral/base.py:8:33: F401 [*] `tardis.constants` imported but unused
tardis/spectrum/formal_integral/base.py:38:9: RET506 [*] Unnecessary `else` after `raise` statement
tardis/spectrum/formal_integral/base.py:115:5: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral/formal_integral_cuda.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/formal_integral_cuda.py:85:5: RET505 [*] Unnecessary `else` after `return` statement
tardis/spectrum/formal_integral/formal_integral_cuda.py:124:5: RET505 [*] Unnecessary `else` after `return` statement
tardis/spectrum/formal_integral/formal_integral_numba.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/formal_integral_numba.py:29:5: RET505 [*] Unnecessary `else` after `return` statement
tardis/spectrum/formal_integral/formal_integral_numba.py:59:5: RET505 [*] Unnecessary `else` after `return` statement
tardis/spectrum/formal_integral/formal_integral_numba.py:134:12: NPY201 `np.trapz` will be removed in NumPy 2.0. Use `numpy.trapezoid` on NumPy 2.0, or ignore this warning on earlier versions.
tardis/spectrum/formal_integral/tests/test_cuda_formal_integral.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/tests/test_cuda_formal_integral.py:9:5: F401 [*] `tardis.spectrum.formal_integral.base.interpolate_integrator_quantities` imported but unused
tardis/spectrum/formal_integral/tests/test_cuda_formal_integral.py:15:61: F401 [*] `tardis.spectrum.formal_integral.source_function.SourceFunctionSolver` imported but unused
tardis/spectrum/formal_integral/tests/test_formal_integral.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/tests/test_formal_integral.py:7:55: F401 [*] `tardis.transport.montecarlo.configuration.montecarlo_globals` imported but unused
tardis/spectrum/formal_integral/tests/test_formal_integral.py:13:27: F401 [*] `tardis.spectrum.formal_integral.formal_integral_cuda.calculate_p_values` imported but unused
tardis/spectrum/formal_integral/tests/test_formal_integral.py:14:5: F401 [*] `tardis.spectrum.formal_integral.formal_integral_cuda.intensity_black_body_cuda` imported but unused
tardis/spectrum/formal_integral/tests/test_numba_formal_integral.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/spectrum/formal_integral/tests/test_numba_formal_integral.py:46:16: NPY201 `np.trapz` will be removed in NumPy 2.0. Use `numpy.trapezoid` on NumPy 2.0, or ignore this warning on earlier versions.
tardis/spectrum/formal_integral/tests/test_source_function.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/tests/test_tardis_full_formal_integral.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/tests/test_tardis_full_formal_integral.py:3:17: F401 [*] `numpy` imported but unused
tardis/transport/montecarlo/packets/packet_collections.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/packets/packet_trackers.py:250:1: W293 Blank line contains whitespace
tardis/transport/montecarlo/packets/radiative_packet.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/transport/montecarlo/packets/tests/test_packet.py:21:1: E402 Module level import not at top of file
tardis/transport/montecarlo/single_packet_loop.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/visualization/plot_util.py:54:5: RET505 [*] Unnecessary `else` after `return` statement
tardis/visualization/sdec/util.py:115:9: RET506 [*] Unnecessary `else` after `raise` statement
tardis/visualization/sdec/util.py:273:9: RET506 [*] Unnecessary `else` after `raise` statement
tardis/visualization/tests/test_plot_util.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/visualization/tools/sdec_plot.py:8:1: I001 [*] Import block is un-sorted or un-formatted
tardis/visualization/tools/tests/test_liv_plot.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/visualization/tools/tests/test_liv_plot.py:2:18: F401 [*] `copy.deepcopy` imported but unused
tardis/visualization/tools/tests/test_liv_plot.py:14:55: F401 [*] `tardis.workflows.standard_tardis_workflow.StandardTARDISWorkflow` imported but unused
tardis/visualization/tools/tests/test_liv_plot.py:301:29: ISC003 [*] Explicitly concatenated string should be implicitly concatenated
tardis/visualization/tools/tests/test_liv_plot.py:504:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_liv_plot.py:509:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_liv_plot.py:514:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_liv_plot.py:519:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_liv_plot.py:522:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_liv_plot.py:555:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_liv_plot.py:561:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_liv_plot.py:563:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_liv_plot.py:566:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_liv_plot.py:580:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_liv_plot.py:583:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_liv_plot.py:595:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_liv_plot.py:599:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_liv_plot.py:602:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:2:1: I001 [*] Import block is un-sorted or un-formatted
tardis/visualization/tools/tests/test_sdec_plot.py:3:18: F401 [*] `copy.deepcopy` imported but unused
tardis/visualization/tools/tests/test_sdec_plot.py:16:55: F401 [*] `tardis.workflows.standard_tardis_workflow.StandardTARDISWorkflow` imported but unused
tardis/visualization/tools/tests/test_sdec_plot.py:282:29: ISC003 [*] Explicitly concatenated string should be implicitly concatenated
tardis/visualization/tools/tests/test_sdec_plot.py:338:9: F811 Redefinition of unused `test_generate_plot_mpl` from line 247
tardis/visualization/tools/tests/test_sdec_plot.py:415:85: W291 [*] Trailing whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:430:46: W291 [*] Trailing whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:431:60: W291 [*] Trailing whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:434:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:447:49: W291 [*] Trailing whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:451:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:457:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:485:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:532:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:536:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:538:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:550:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:553:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:556:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:563:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:564:53: W291 [*] Trailing whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:574:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:578:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:581:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:591:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:595:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:597:1: W293 [*] Blank line contains whitespace
tardis/visualization/widgets/tests/test_line_info.py:9:1: E402 Module level import not at top of file
tardis/workflows/simple_tardis_workflow.py:252:17: G004 Logging statement uses f-string
tardis/workflows/simple_tardis_workflow.py:480:17: G004 Logging statement uses f-string
Found 105 errors.
[*] 85 fixable with the `--fix` option (3 hidden fixes can be enabled with the `--unsafe-fixes` option).

codecov · 2025-09-02T12:32:50Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.51%. Comparing base (f8a5efd) to head (083d089).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3277      +/-   ##
==========================================
+ Coverage   68.25%   68.51%   +0.26%     
==========================================
  Files         175      175              
  Lines       13337    13385      +48     
==========================================
+ Hits         9103     9171      +68     
+ Misses       4234     4214      -20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tardis/visualization/tools/tests/test_sdec_plot.py

tardis-bot · 2025-09-08T14:09:28Z

*beep* *bop*
Hi human,
I ran benchmarks as you asked comparing master (f8a5efd) and the latest commit (083d089).
Here are the logs produced by ASV.
Results can also be downloaded as artifacts here.

Significantly changed benchmarks:

All benchmarks:

Benchmarks that have stayed the same:

| Change   | Before [6802bfaf] <master>   | After [083d089e]    | Ratio   | Benchmark (Parameter)                                                                                                               |
|----------|------------------------------|---------------------|---------|-------------------------------------------------------------------------------------------------------------------------------------|
|          | 25.9±7μs                     | 35.2±10μs           | ~1.36   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list |
|          | 48.1±30μs                    | 62.1±30μs           | ~1.29   | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter                                          |
|          | 1.38±0.3μs                   | 1.75±0.5μs          | ~1.27   | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line                    |
|          | 2.67±0.4ms                   | 3.14±0.4ms          | ~1.18   | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop                        |
|          | 5.72±1μs                     | 6.49±1μs            | ~1.13   | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket                                           |
|          | 491±200ns                    | 551±200ns           | ~1.12   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation                              |
|          | 40.3±0.3s                    | 36.5±0.05s          | ~0.91   | run_tardis.BenchmarkRunTardis.time_run_tardis                                                                                       |
|          | 3.60±0.4μs                   | 3.13±0.5μs          | ~0.87   | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell                              |
|          | 1.12±0m                      | 57.6±0.05s          | ~0.86   | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking                                                                      |
|          | 3.57±0.01ms                  | 2.99±0.01ms         | ~0.84   | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter')                                     |
|          | 451±200ns                    | 481±200ns           | 1.07    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation                                      |
|          | 659±0.5ns                    | 704±0.8ns           | 1.07    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter                                       |
|          | 2.26±2μs                     | 2.34±2μs            | 1.04    | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators       |
|          | 37.2±0.03μs                  | 38.7±0.02μs         | 1.04    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list                  |
|          | 1.12±0μs                     | 1.16±0.01μs         | 1.03    | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary                |
|          | 4.25±0.02ms                  | 4.32±0.04ms         | 1.02    | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom')                                   |
|          | 2.55±0.02ms                  | 2.59±0.01ms         | 1.02    | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop                             |
|          | 58.2±0.5ms                   | 59.7±0.2ms          | 1.02    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe                  |
|          | 3.51±0.6μs                   | 3.58±0.3μs          | 1.02    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket                                       |
|          | 1.06±0m                      | 1.05±0m             | 1.00    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions                                 |
|          | 1.17±0μs                     | 1.13±0μs            | 0.96    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body                                       |
|          | 7.60±3μs                     | 7.29±2μs            | 0.96    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley                                    |
|          | 510±200ns                    | 481±200ns           | 0.94    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation                                |
|          | 42.7±20μs                    | 39.3±20μs           | 0.92    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission                                         |

If you want to see the graph of the results, you can check it here

tardis/visualization/tools/tests/test_liv_plot.py

tardis/visualization/tools/tests/test_sdec_plot.py

andrewfullard

One minor change, add global RTOL to each test file set to 1e-12 and apply to tests

tardis/visualization/tools/tests/test_liv_plot.py

tardis/visualization/tools/tests/test_sdec_plot.py

jvshields · 2025-09-16T14:30:58Z

tardis/visualization/tools/tests/test_sdec_plot.py

+        self, plotter_calculate_plotting_data_from_workflow, sdec_regression_data
+    ):
+        param_idx = plotter_calculate_plotting_data_from_workflow._param_idx
+        regression_file = sdec_regression_data / f"test_calculate_plotting_data__plotter_calculate_plotting_data{param_idx}__.h5"


I am very slightly worried about this because it seems like something we would have to manually update and wouldn't be generated by the normal regression data thing we do. Is that true? And if so would it be possible to stick it on to one of our sync methods somehow?

Right now it compares to the existing saved regression data so that generating new one is not needed. Adding regression data would mostly mean duplicating the items already saved. Using the sync method will mean generating new data.I don't think we would want new data for a very similar functionality, would we? The workflows will always produce the same data the simulation produced with the same configuration right?

Oh I see now. Yes, piggybacking off existing non-workflow regression data is fine and good and I'm happy with that. I will instead just request you add a comment at the top of the test that points this out explicitly because we will run into problems generating regression data if this test ever runs before that one. Currently that shouldn't happen since the workflow tests are run last, but we've moved tests around before and it'd be nice to know more easily if something breaks as a result.

andrewfullard reviewed Sep 2, 2025

View reviewed changes

tardis/visualization/tools/tests/test_sdec_plot.py Outdated Show resolved Hide resolved

atharva-2001 linked an issue Sep 8, 2025 that may be closed by this pull request

Make sure all visualizations work with Workflows (if possible) #3189

Closed

atharva-2001 marked this pull request as ready for review September 8, 2025 13:25

atharva-2001 changed the title ~~Viz modules from_workflow tests~~ Viz modules from_workflow tests Sep 8, 2025

wkerzendorf reviewed Sep 8, 2025

View reviewed changes

tardis/visualization/tools/tests/test_liv_plot.py Outdated Show resolved Hide resolved

andrewfullard reviewed Sep 8, 2025

View reviewed changes

tardis/visualization/tools/tests/test_sdec_plot.py Outdated Show resolved Hide resolved

andrewfullard requested changes Sep 8, 2025

View reviewed changes

atharva-2001 added 15 commits September 9, 2025 16:30

sdec tests test

918f460

more tests

bb485ba

use existing regression data

3eca5e5

image tests

e3c1f02

sdec fixture

c123ed4

remove check exact

37876f0

liv plot tests

42accf7

atol, rtol

0bfa381

reduce rtol value

fe1bd14

duplicate fixture

250f810

trigger

df28fd4

remove extra self

17d6d12

increase rtol value

ba8f670

unit tests

2b9d821

reset tests

cf47101

atharva-2001 force-pushed the from_workflow_tests branch from 7b25961 to cf47101 Compare September 9, 2025 11:00

atharva-2001 added 3 commits September 9, 2025 16:31

increase rtol after rebasing

8081982

rtol -14

48eb5e2

rtol value

13ac90c

atharva-2001 added 3 commits September 9, 2025 18:25

rtol value increase

19623bd

rtol value increase

51310f9

reset tests

cf3ef43

andrewfullard requested review from andrewfullard and wkerzendorf September 9, 2025 13:49

wkerzendorf reviewed Sep 9, 2025

View reviewed changes

tardis/visualization/tools/tests/test_liv_plot.py Outdated Show resolved Hide resolved

andrewfullard reviewed Sep 9, 2025

View reviewed changes

tardis/visualization/tools/tests/test_sdec_plot.py Outdated Show resolved Hide resolved

variable naming and scientific notation

5628ff2

atharva-2001 requested a review from wkerzendorf September 15, 2025 11:58

atharva-2001 added this to DevOps Sep 15, 2025

github-project-automation bot moved this to Todo in DevOps Sep 15, 2025

atharva-2001 moved this from Todo to waiting for review in DevOps Sep 15, 2025

andrewfullard added testing 🚦 visualization labels Sep 15, 2025

andrewfullard mentioned this pull request Sep 15, 2025

Use new workflow_simple fixture to test workflows #3304

Open

variables

fbb6237

andrewfullard previously approved these changes Sep 15, 2025

View reviewed changes

andrewfullard enabled auto-merge (squash) September 15, 2025 14:26

jvshields reviewed Sep 16, 2025

View reviewed changes

Add comment

083d089

atharva-2001 dismissed andrewfullard’s stale review via 083d089 September 22, 2025 14:10

jvshields approved these changes Sep 22, 2025

View reviewed changes

andrewfullard approved these changes Sep 22, 2025

View reviewed changes

andrewfullard merged commit 2c37e97 into tardis-sn:master Sep 22, 2025
25 of 26 checks passed

github-project-automation bot moved this from waiting for review to Done in DevOps Sep 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Viz modules `from_workflow` tests #3277

Viz modules `from_workflow` tests #3277

Uh oh!

atharva-2001 commented Sep 1, 2025 •

edited

Loading

Uh oh!

tardis-bot commented Sep 1, 2025

Uh oh!

tardis-bot commented Sep 1, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

tardis-bot commented Sep 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

andrewfullard left a comment

Uh oh!

Uh oh!

Uh oh!

jvshields Sep 16, 2025

Uh oh!

atharva-2001 Sep 16, 2025

Uh oh!

jvshields Sep 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Viz modules from_workflow tests #3277

Viz modules from_workflow tests #3277

Uh oh!

Conversation

atharva-2001 commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

📌 Resources

🚦 Testing

☑️ Checklist

Uh oh!

tardis-bot commented Sep 1, 2025

Uh oh!

tardis-bot commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

tardis-bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andrewfullard left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jvshields Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

atharva-2001 Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

jvshields Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Viz modules `from_workflow` tests #3277

Viz modules `from_workflow` tests #3277

atharva-2001 commented Sep 1, 2025 •

edited

Loading

tardis-bot commented Sep 1, 2025 •

edited

Loading

codecov bot commented Sep 2, 2025 •

edited

Loading

tardis-bot commented Sep 8, 2025 •

edited

Loading