users: change user role #1506
Merged
users: change user role #1506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastercactapus
requested changes
May 6, 2021
Member
mastercactapus
left a comment
There was a problem hiding this comment.
A few high-level things we could
Co-authored-by: Nathaniel Caza <[email protected]>
…to edit-user-role
Forfold
requested changes
May 6, 2021
Contributor
There was a problem hiding this comment.
Edit: Fixed in latest commit
I got this error when trying to update a user other than myself to admin, in the UI console:
The network tab showed this response on the request:
{
"errors": [
{
"message": "Cannot query field \"setUserRole\" on type \"Mutation\".",
"locations": [{ "line": 2, "column": 3 }],
"extensions": { "code": "GRAPHQL_VALIDATION_FAILED" }
},
{
"message": "Unknown type \"SetUserRoleInput\".",
"locations": [{ "line": 1, "column": 1 }],
"extensions": { "code": "GRAPHQL_VALIDATION_FAILED" }
}
],
"data": null
}
Forfold
requested changes
May 6, 2021
Co-authored-by: Nathaniel Cook <[email protected]>
Forfold
previously approved these changes
May 10, 2021
Forfold
previously approved these changes
May 11, 2021
Forfold
previously approved these changes
May 11, 2021
Forfold
approved these changes
May 11, 2021
mastercactapus
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
This PR provides the ability for admins to change user roles.
Which issue(s) this PR fixes:
Part of #1247
Describe any introduced user-facing changes:
Admins will be able to see 'Edit' icon on the user details page.
After that, there will be an option to check/uncheck the admin role option.
Checking it will set the user as admin, unchecking will set the role to user.
If the logged-in user is already an admin, unchecking the checkbox will show a warning notice mentioning the change in role and it's effects.
Describe any introduced API changes:
A split logic has been applied to the
updateUsermutation.Whenever the
rolefield is specified, the logic will go to a different store method that updates the user role, else it will go to the store update a user logic.This decision was made since even though there is currently no UI for updateUser fields like name, email, etc that might change in the future (and is possible today via the graphql playground) editing user fields like name, email, etc could be done by the user themselves. But in the case of changing user's role, this operation is strictly limited to admins only. No non-admin user should be allowed to make themselves as an admin. So, in order to keep the two different permission checks separate for updating user fields and changing user role, the logic is split up accordingly.