ui: fix default value not set for temp sched dialog#3380
Merged
Conversation
allending313
approved these changes
Oct 25, 2023
KatieMSB
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3377
Fixes an issue where the default value was not set on the temporary schedule dialog, so the incoming data was not what was expected.
Also resolves a console error where
userIDis not a valid prop for a native HTML element.Out of scope:
There's another console error related to
findDOMNodebeing disabled withReact.StrictModeenabled. This seems to be an issue with the transition library we are using, as this prop is not seen within our codebase. It will be worth looking into updating this package.