Adding ScanISO Scanner #225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Adding in ScanISO, which extracts file names, file sizes, and files for processing from ISO files. By default, names and sizes are collected, but files are not passed back into Strelka. In several larger ISOs, recursive extraction led to 1:10000 scan ratio, leading to a potentially overwhelmed system. A limit can be applied, but by default it is off.
This also removes iso scanning from ScanLibArchive, as that scanner's purpose was not to extract metadata about ISOs, but to pass pass files from several compressed file types (e.g., ISOs, CABs) back into Strelka. ScanISO and ScanLibArchive both scanning ISO files would be redundant.
Describe testing procedures
Executed ScanISO against 10+ ISO files, ranging from 50KB to 50MB.
Sample output
Checklist