-
Notifications
You must be signed in to change notification settings - Fork 131
Add OpenTelemetry Tracing to Backend #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in traces.py, change net to strelka_net
phutelmyer
reviewed
Feb 14, 2023
# Conflicts: # build/docker-compose.yaml
phutelmyer
approved these changes
Feb 15, 2023
Contributor
phutelmyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, tested great. Didn't seem to run into any problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Adds OpenTelemetry integration to the backend. Allows end-users to view traces for requests processed by Strelka.
Adds a Jaeger all-in-one container for trace visualization.
Converts backend config parsing to a class BackendConfig to improve code re-use.
Modify
__main__.pyandstrelka-backendto support BackendConfig class.Move coordinator setup from
strelka-backendto Backend class.Removes the deletion of setuptools at build time, it's a runtime dependency.
Describe testing procedures
Navigate to http://localhost:16686/, choose the
strelka.backend.workerService. Click "Find Traces".Observe a trace returned in results.
Sample output
Checklist