Address Issues with lstrip() in taste_yara, pcapng #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.4.0 to 0.7.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](golang/net@v0.4.0...v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
phutelmyer
reviewed
Feb 19, 2023
| "test.tlsh": { | ||
| "mime": ["application/x-mach-binary"], | ||
| "yara": ["macho_file", "credit_cards"], | ||
| "yara": unordered(["macho_file", "credit_cards"]), |
Contributor
There was a problem hiding this comment.
Good call on the inclusion of unordered in this test.
phutelmyer
approved these changes
Feb 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Fixes #284
Refactors tasting to process files first without modification.
Adds conditional transformations that occur with an additional
taste_yara()pass.Example: If a file starts with whitespace, the data is run through
lstrip()before tasting again, and adding to the previous taste results.Preserves existing behavior that excludes transformed files from
taste_mime(). It can be enabled with a minor performance hit, but there's no clear benefit to the magic library yet.Adds a test that includes HTML with leading whitespace.
Updated config tests to match.
Performance difference is negligible:
Describe testing procedures
Sample output
If this change modifies Strelka's output, then please include a sample of the output here.
Checklist