python-magic needs a None value to use the default mime DB #349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
The default value for the mime_db file must be None in order for it to use the default database file in the
/usrtree. Defaulting to an empty string""causes Magic to throw an exception due to a missing file at that empty path.This likely only affects users that need to generate the config file via yaml formatters that are unable to convert
Nonetonull.I did not create an issue. Let me know if you'd like one created and linked to this PR.
Describe testing procedures
Start the backend container with the
tasting.mime_dbsetting deleted from the backend config file. The container will crash. Pull the fixed image and start a new container, still with the deleted setting. The container should not crash, and should start up normally.Sample output
N/A
Checklist