Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Derekt2
Copy link
Contributor

@Derekt2 Derekt2 commented Mar 28, 2023

Describe the change

  • Reduces image size by 26%+, Most of this is done by deleting unused zeek components.
  • Used docker buildkit to cache apt and pip install steps, this increases RE-build time only, but improves it up to 35% (depending on which step needs rebuilt) NOTE BUILDKIT IS NOW REQUIRED: This shouldn't be an issue as it is shipped with Docker since 2018.
  • Bumped dependencies to latest where possible
  • Removed unused python dependencies in requirements.txt
  • Removed verbose logging from scan_vba scanner
  • Updated floss binary path to remove /tmp before runtime

Describe testing procedures
I made sure all tests passed, ran the docker-compose up with local building, and fileshot in all the binaries in the fixtures directory. No errors were detected and the output looks good.

Sample output
No significant change in output that I detected.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@Derekt2
Copy link
Contributor Author

Derekt2 commented Mar 28, 2023

I'm not sure why it says the imports are wrong for scan_vba. running ISORT locally doesn't show any issues.
image

@phutelmyer phutelmyer added the enhancement New feature or request label Mar 28, 2023
@phutelmyer phutelmyer merged commit 5ba5f1e into target:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants