Allow GateKeeper to be optional in FrontEnd #364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
This change allows the Gatekeeper to be omitted from a Strelka deployment. The motivation here is simply to drop a dependency if a use case has no need for the Gatekeeper. This may be the case if a calling system already has a cache.
Originally implemented in: sublime-security#9. Merging this only conflicted due to adjacent comments. I did clean that change up a bit as well.
The documentation here could be updated to mention that the Gatekeeper may be omitted. And this section could mention that if Gatekeeper is to be omitted, the
gatekeeperentry should be dropped fromfrontend.yaml.Describe testing procedures
I removed
gatekeeperfrom the compose file and removed thegatekeeperconfiguration fromfrontend.yaml. I then submitted a few test files and validated that they were analyzed. I also tested with gatekeeper enabled and saw no issues + added some temp logging to ensure that gatekeeper was used.Sample output
If this change modifies Strelka's output, then please include a sample of the output here.
Checklist